Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for osx-arm64 for Java and Rust #8

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

mrT23
Copy link
Contributor

@mrT23 mrT23 commented Oct 18, 2024

This PR extends the support of multispy for Java and Rust also to Mac computers

Example results

On Rust, for example, I tested it on the repo: https://github.com/rust-lang/rfcbot-rs

project_dir = workspace/rfcbot-rs-master'
rel_file = "src/config.rs"

Results:

================
For the file '/workspace/rfcbot-rs-master/src/config.rs', here are the files referenced by it (context):

/workspace/rfcbot-rs-master/src/macros.rs


================
For the file '/Users/talrid/Git/rfcbot-rs-master/src/config.rs', here are the files referencing it (reverse context):

/workspace/rfcbot-rs-master/src/scraper.rs
/workspace/rfcbot-rs-master/src/main.rs
/workspace/rfcbot-rs-master/src/github/command.rs
================

Related: #28

@mrT23
Copy link
Contributor Author

mrT23 commented Oct 18, 2024

@microsoft-github-policy-service agree company="qodo"

@LakshyAAAgrawal
Copy link
Collaborator

LakshyAAAgrawal commented Oct 20, 2024

Hi @mrT23 ,

Thanks a lot for the PR.

Could you please confirm if the changes are similar to the ones made at microsoft/monitors4codegen#18 by @tonyfettes?

It seems to me that the 2 PRs are targetting different mac versions (intel vs M series macs, I believe). Could you please confirm that, and add documentation clarifying the same?

I will proceed with merging this immediately after merging #7.

@tonyfettes, I would be grateful if you could also provide your changes in microsoft/monitors4codegen#18 to multilspy!

@mrT23
Copy link
Contributor Author

mrT23 commented Oct 28, 2024

The PRs are similar. mine contains additional needed changes.

In addition, I ran and validated mine

image

@mrT23 mrT23 closed this Nov 17, 2024
@LakshyAAAgrawal
Copy link
Collaborator

Dear @mrT23, I apologize for getting back so late on this. I would be glad if you could reopen this PR, and I will proceed to work on it and merge it immediately.

@themichaelusa
Copy link
Contributor

@LakshyAAAgrawal Can you merge this?

@LakshyAAAgrawal LakshyAAAgrawal merged commit c918061 into microsoft:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants