Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve USB HID error scenario handling #645

Merged

Conversation

joschock
Copy link
Contributor

Description

This converts an assert to an error message on failure to re-submit the async interrupt for USB HID devices. In some scenarios (such a device removal), this assert was triggering even though failure to re-submit the async interrupt is expected (because the device is no longer present.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

No longer observe spurious asserts on unplug of USB devices.

Integration Instructions

N/A

@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Mar 11, 2025
@joschock joschock changed the base branch from dev/202405 to dev/202411 March 11, 2025 07:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 11.59%. Comparing base (8285ec4) to head (c290ffd).

Files with missing lines Patch % Lines
HidPkg/UsbHidDxe/UsbHidDxe.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #645   +/-   ##
===========================================
  Coverage       11.59%   11.59%           
===========================================
  Files             132      132           
  Lines           21559    21559           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19026    19026           
  Partials           34       34           
Flag Coverage Δ
HidPkg 2.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki
Copy link
Member

This branch is currently targeting dev/202411. @apop5, should that still exist? The default branch is dev/202405 and I thought we're moving to dev/202502.

@joschock
Copy link
Contributor Author

This branch is currently targeting dev/202411. @apop5, should that still exist? The default branch is dev/202405 and I thought we're moving to dev/202502.

Bad guess on my part; happy to target whatever branch makes sense.

@joschock joschock force-pushed the personal/joschock/usb_hid_error_handling branch from d8110b9 to 276fdad Compare March 11, 2025 15:50
@joschock joschock changed the base branch from dev/202411 to dev/202405 March 11, 2025 15:50
@joschock
Copy link
Contributor Author

This branch is currently targeting dev/202411. @apop5, should that still exist? The default branch is dev/202405 and I thought we're moving to dev/202502.

Bad guess on my part; happy to target whatever branch makes sense.

Retargeted to dev/202405 (dev/202505 doesn't exist yet).

@makubacki makubacki requested a review from apop5 March 20, 2025 20:35
@apop5 apop5 merged commit 2761c3a into microsoft:dev/202405 Mar 29, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants