-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve USB HID error scenario handling #645
Improve USB HID error scenario handling #645
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #645 +/- ##
===========================================
Coverage 11.59% 11.59%
===========================================
Files 132 132
Lines 21559 21559
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19026 19026
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This branch is currently targeting |
Bad guess on my part; happy to target whatever branch makes sense. |
d8110b9
to
276fdad
Compare
Retargeted to dev/202405 (dev/202505 doesn't exist yet). |
Description
This converts an assert to an error message on failure to re-submit the async interrupt for USB HID devices. In some scenarios (such a device removal), this assert was triggering even though failure to re-submit the async interrupt is expected (because the device is no longer present.
How This Was Tested
No longer observe spurious asserts on unplug of USB devices.
Integration Instructions
N/A