Fast forward from main with advanced logger buffer and PCR6 change #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og levels This change now sets the in-memory advanced logger buffer to contain all debug levels. The DEBUG_NOISY flag now just controls the serial output ---- #### AI description (iteration 1) #### PR Classification This PR makes a configuration update to enable UEFI in-memory logging at all debug levels by default. #### PR Summary The changes adjust the default debug levels for UEFI diagnostics in both X64 and AARCH64 DSC files, ensuring all log messages are captured. - `MsvmPkg/MsvmPkgX64.dsc`: Updated the `PcdAdvancedLoggerHdwPortDebugPrintErrorLevel` with conditional logic based on `DEBUG_NOISY` and set `PcdDebugPrintErrorLevel` to 0x804FEF4B. - `MsvmPkg/MsvmPkgAARCH64.dsc`: Made analogous modifications to apply verbose logging under the `DEBUG_NOISY` condition and defaulted `PcdDebugPrintErrorLevel` to 0x804FEF4B. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #59031346
This change simply measures the architecture that UEFI is running under and puts it into PCR6. NOTE: Tested so far by confirming these logs show up: ``` VmMeasurementEntry() - Logged UUID: 1FBC6B5C-49CF-447E-881B-5CE85B2F3A68 (size=0x2A) status 0x0 VmMeasurementEntry() - Logged Architecture: X64 (size=0x11) status 0x0 ``` ---- #### AI description (iteration 2) #### PR Classification Enhancement to include CPU architecture measurement into PCR6 logging for TPM validation. #### PR Summary This PR extends the TPM measurement functionality by adding a new block that logs the CPU architecture (X64 or AARCH64) into PCR6 and refines associated comments for clarity. - In `MsvmPkg/VmMeasurementDxe/VmMeasurementDxe.c`, a new conditional block is added to measure and log the CPU architecture by calling TpmMeasureAndLogData. - The comment for UUID measurement is updated for improved clarity. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #59906760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fast forwards main to match closed source, picking two commits that default the advanced logger's in-memory buffer to the
DEBUG_NOISYequivalent by default, and a change to measure the architecture into PCR6