FIX: Skipping long running test related with wstring conversion #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrata-ms
requested review from
bewithgaurav,
gargsaumya,
jahnvi480 and
sumitmsft
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses performance issues in CI pipelines by skipping 14 long-running stress tests in the test_013_sqlwchar_conversions.py file. These tests exercise UTF-16 surrogate pair handling and wstring conversions, which are particularly time-consuming on Manylinux64 environments.
Key changes:
- Added
@pytest.mark.skipdecorators to 14 test methods covering various Unicode/wstring conversion scenarios - Tests span both platform-specific (Unix/Linux) and common test classes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gargsaumya
approved these changes
Dec 19, 2025
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.helpers.py: 67.5%
mssql_python.pybind.ddbc_bindings.cpp: 69.3%
mssql_python.pybind.ddbc_bindings.h: 71.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 83.9%🔗 Quick Links
|
bewithgaurav
approved these changes
Dec 19, 2025
jahnvi480
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates the test suite in
tests/test_013_sqlwchar_conversions.pyby marking several long-running tests as skipped using the@pytest.mark.skipdecorator. The reason provided is that these stress tests have been moved due to their long execution time, particularly affecting Manylinux64 runs. This helps streamline the test runs and avoid timeouts or delays in CI pipelines.Test Suite Management:
@pytest.mark.skipto multiple test methods to exclude long-running stress tests from regular test runs, with a note that these have been moved due to their duration on Manylinux64 environments. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]