Skip to content

Conversation

@jahnvi480
Copy link
Contributor

@jahnvi480 jahnvi480 commented Dec 19, 2025

Work Item / Issue Reference

AB#41191

GitHub Issue: #<ISSUE_NUMBER>


Summary

This pull request updates the mssql-python package to version 1.1.0, introducing several critical bug fixes, enhancements, and improvements to platform-specific packaging and metadata. The update also removes unused global connection cleanup logic from the package initialization. Below are the most important changes:

Major Enhancements and Bug Fixes

  • Critical Stability and Security Fixes:
    • Introduced thread-safe encoding/decoding with mutex-based protection and strict validation for SQL_WCHAR types.
    • Fixed a critical double-free issue on Linux, improved UTF-16 string decoding, ensured connection pooling isolation resets, corrected connection string escaping, improved NULL parameter array handling, ensured consistent query timeout, fixed IntegrityError detection, and improved sensitive parameter filtering.
  • Documentation Update:
    • Updated the PyPI_Description.md to reflect new features, enhancements, and bug fixes for version 1.1.0.

Package Initialization and Versioning

  • Version Bump:
    • Updated the package version from 1.0.0 to 1.1.0 in both mssql_python/__init__.py and setup.py.
  • Removed Connection Cleanup Logic:
    • Eliminated global weakref-based connection tracking and atexit cleanup logic from mssql_python/__init__.py, as it is no longer needed.

Packaging and Distribution Improvements

  • Platform-Specific Packaging:
    • Refactored setup.py to use consistent double quotes, improved architecture and platform tag detection, and expanded logic for adding platform-specific package data for Windows, macOS, and Linux.
  • Metadata Consistency:
    • Updated all metadata fields (e.g., author, description, classifiers) and ensured consistent formatting and requirements in setup.py.

These changes collectively improve package stability, security, and cross-platform compatibility, while also ensuring accurate documentation and streamlined packaging.

Copilot AI review requested due to automatic review settings December 19, 2025 09:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the mssql-python package from version 1.0.0 to 1.1.0, introducing critical bug fixes, thread-safety enhancements, and improved cross-platform packaging. The release focuses on stability improvements, particularly for Linux platforms, and resolves several issues related to connection pooling, string encoding, and error handling.

  • Updated package version to 1.1.0 across all relevant files
  • Standardized code formatting in setup.py by converting single quotes to double quotes
  • Enhanced documentation with detailed release notes covering thread-safety improvements and critical bug fixes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
setup.py Updated version to 1.1.0 and refactored entire file to use double quotes consistently; improved code formatting with better line breaks and spacing for platform-specific logic
mssql_python/init.py Updated __version__ from "1.0.0" to "1.1.0"
PyPI_Description.md Replaced v1.0.0 release notes with comprehensive v1.1.0 documentation detailing thread-safety enhancements and critical bug fixes including Linux stability, connection pooling, UTF-16 decoding, and more

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

76%


📈 Total Lines Covered: 5357 out of 7037
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

  • mssql_python/init.py (100%)

Summary

  • Total: 1 line
  • Missing: 0 lines
  • Coverage: 100%

📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.helpers.py: 67.5%
mssql_python.pybind.ddbc_bindings.cpp: 69.3%
mssql_python.pybind.ddbc_bindings.h: 71.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 83.9%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

@jahnvi480 jahnvi480 changed the title Release/1.1.0 RELEASE: v1.1.0 Dec 19, 2025
@github-actions github-actions bot added the pr-size: medium Moderate update size label Dec 19, 2025
@jahnvi480 jahnvi480 merged commit f875072 into main Dec 19, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: medium Moderate update size

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants