Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cibir tests to Connection Pool tests #4952

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Mar 27, 2025

Description

Add CIBIR tests back to the connection pool API tests.

Testing

Adding new tests

Documentation

N/A.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (9348a4a) to head (de71b76).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4952      +/-   ##
==========================================
- Coverage   87.37%   87.08%   -0.29%     
==========================================
  Files          57       57              
  Lines       17951    17982      +31     
==========================================
- Hits        15685    15660      -25     
- Misses       2266     2322      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anrossi anrossi changed the title !!DON'T MERGE!! Add Cibir tests to Connection Pool tests Add Cibir tests to Connection Pool tests Apr 1, 2025
@anrossi anrossi marked this pull request as ready for review April 1, 2025 05:45
@anrossi anrossi requested a review from a team as a code owner April 1, 2025 05:45
@ProjectsByJackHe
Copy link
Contributor

I stepped through GDB to try and figure out why https://github.com/microsoft/msquic/actions/runs/14206028558/job/39804328737?pr=4952 is failing, and it seems to be because of a watchdog timeout firing. (Not in this PR) Could we cut down on the flakiness by increasing the timeout or something?

@anrossi
Copy link
Contributor Author

anrossi commented Apr 1, 2025 via email

@ProjectsByJackHe
Copy link
Contributor

ProjectsByJackHe commented Apr 1, 2025

We can increase the timeout, but it's timing out after 60 seconds. Shouldn't a handshake, even with loss, complete well before then?

I enqueued a re-run. But given the previous 2 enumerations took 40+ seconds, it may be the case that we are doing many many handshakes with loss and it's just taking too long. Unless you're more familiar with that test and it's timing out on a SINGLE handshake (with loss). If that's the case, we'll need to investigate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants