Optimize searching for packets in the LostPackets list to see if they… #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are acknowledged when processing AckBlocks
nibanks
reviewed
Feb 11, 2025
nibanks
reviewed
Feb 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4806 +/- ##
==========================================
- Coverage 87.02% 85.64% -1.39%
==========================================
Files 56 56
Lines 17422 17425 +3
==========================================
- Hits 15162 14924 -238
- Misses 2260 2501 +241 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Nick Banks <[email protected]>
… are acknowledged when processing AckBlocks
nibanks
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… are acknowledged when processing AckBlocks
Description
Improve performance when searching for packets in LostPackets list to see if they are acknowledged when processing AckBlocks
Part of #4772.
Testing
Done manual testing.
Documentation
No