Add support for both Qtip and UDP traffic for Server Listeners. #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 85.92% 86.55% +0.62%
==========================================
Files 56 56
Lines 17425 17459 +34
==========================================
+ Hits 14973 15111 +138
+ Misses 2452 2348 -104 ☔ View full report in Codecov by Sentry. |
ProjectsByJackHe
added
Partner: SQL
nibanks
reviewed
Feb 14, 2025
| @@ -6754,6 +6754,26 @@ QuicConnParamSet( | |||
| break; | |||
| #endif | |||
|
|
|||
| #ifdef QUIC_API_ENABLE_PREVIEW_FEATURES | |||
There was a problem hiding this comment.
We only have these ifdef checks in the public headers. We always compile in the preview features internally.
nibanks
reviewed
Feb 14, 2025
Comment on lines
+213
to
+221
| // | ||
| // Whether to use QTIP on sends for this connection. | ||
| // | ||
| BOOLEAN SendViaQtip : 1; | ||
|
|
||
| // | ||
| // Whether to allow QTIP on receives for this connection. | ||
| // | ||
| BOOLEAN RecvViaQtip : 1; |
There was a problem hiding this comment.
Why are you separating out send/receive? I'd recommend just using one variable, UseQTIP.
nibanks
reviewed
Feb 14, 2025
Comment on lines
926
to
+931
| #define QUIC_PARAM_CONN_SEND_DSCP 0x05000019 // uint8_t | ||
|
|
||
| #ifdef QUIC_API_ENABLE_PREVIEW_FEATURES | ||
| #define QUIC_PARAM_CONN_SEND_QTIP 0x0500001A // uint8_t (BOOLEAN) | ||
| #define QUIC_PARAM_CONN_RECV_QTIP 0x0500001B // uint8_t (BOOLEAN) | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #define QUIC_PARAM_CONN_SEND_DSCP 0x05000019 // uint8_t | |
| #ifdef QUIC_API_ENABLE_PREVIEW_FEATURES | |
| #define QUIC_PARAM_CONN_SEND_QTIP 0x0500001A // uint8_t (BOOLEAN) | |
| #define QUIC_PARAM_CONN_RECV_QTIP 0x0500001B // uint8_t (BOOLEAN) | |
| #endif | |
| #define QUIC_PARAM_CONN_SEND_DSCP 0x05000019 // uint8_t | |
| #ifdef QUIC_API_ENABLE_PREVIEW_FEATURES | |
| #define QUIC_PARAM_CONN_SEND_QTIP 0x0500001A // uint8_t (BOOLEAN) | |
| #define QUIC_PARAM_CONN_RECV_QTIP 0x0500001B // uint8_t (BOOLEAN) | |
| #endif |
As I indicated in the other comment, let's just use one new value QUIC_PARAM_CONN_QTIP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we have an execution parameter (QUIC_EXECUTION_CONFIG_FLAG_QTIP) that you set to either process packets via QTIP or normal QUIC/UDP traffic.
For a server listener, that means you can only talk to clients with the same execution profile as you; you either deal over QTIP or QUIC/UDP.
This is inconvenient and sometimes a blocker when you want your listener to accept from clients with varying execution parameters (QTIP through the Azure load balancer, normal QUIC/UDP for on-prem clients)
Closes: #3516
Testing
Test modifications are required to ensure normal QUIC/UDP endpoint is still supported when you set the QUIC_EXECUTION_CONFIG_FLAG_QTIP parameter.
Documentation
N/A