Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly initialize the ip address when setting QUIC_ADDR to the loopback address #4794

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

sm-msft
Copy link
Contributor

@sm-msft sm-msft commented Feb 4, 2025

Description

Fixes #3969.

  • Initialize address field when setting given QUIC_ADDR to loopback address
  • Basic tests for several QuicAddr* API

Testing

Some existing tests hit this code path and new tests have been added for specific checks.

Documentation

No

…ddress

- Basic tests for several QuicAddr* API
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (451c1a8) to head (323cb80).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4794      +/-   ##
==========================================
+ Coverage   87.00%   87.09%   +0.08%     
==========================================
  Files          56       56              
  Lines       17400    17422      +22     
==========================================
+ Hits        15139    15173      +34     
+ Misses       2261     2249      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks
Copy link
Member

nibanks commented Feb 5, 2025

Can you please merge (or rebase) main to get the fixes for the CI?

@sm-msft sm-msft marked this pull request as ready for review February 6, 2025 01:10
@sm-msft sm-msft requested a review from a team as a code owner February 6, 2025 01:10
@nibanks nibanks merged commit 42953c4 into main Feb 6, 2025
483 checks passed
@nibanks nibanks deleted the user/sm/address_init branch February 6, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuicAddrSetToLoopback does not fill remaining bytes with zero
2 participants