Correctly initialize the ip address when setting QUIC_ADDR to the loopback address #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddress - Basic tests for several QuicAddr* API
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4794 +/- ##
==========================================
+ Coverage 87.00% 87.09% +0.08%
==========================================
Files 56 56
Lines 17400 17422 +22
==========================================
+ Hits 15139 15173 +34
+ Misses 2261 2249 -12 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Feb 4, 2025
nibanks
reviewed
Feb 4, 2025
nibanks
reviewed
Feb 4, 2025
nibanks
reviewed
Feb 4, 2025
|
Can you please merge (or rebase) |
nibanks
reviewed
Feb 5, 2025
nibanks
reviewed
Feb 5, 2025
nibanks
reviewed
Feb 5, 2025
nibanks
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3969.
Testing
Some existing tests hit this code path and new tests have been added for specific checks.
Documentation
No