Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datapath_winuser: query RioDispatch only if we are using Rio #4793

Merged

Conversation

jianye-chen
Copy link
Contributor

Description

The WSAIoctl call for RioDispatch might fail, but it should not block initialization if we have already decided not to use Rio.

Testing

Existing tests do not cover the issue fixed by this PR.

Documentation

N/A

@jianye-chen jianye-chen requested a review from a team as a code owner February 4, 2025 02:58
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (1d2b6bd) to head (cea3c78).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4793      +/-   ##
==========================================
- Coverage   86.70%   86.57%   -0.14%     
==========================================
  Files          56       56              
  Lines       17400    17400              
==========================================
- Hits        15087    15064      -23     
- Misses       2313     2336      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks
Copy link
Member

nibanks commented Feb 4, 2025

Description

The WSAIoctl call for RioDispatch might fail, but it should not block initialization if we have already decided not to use Rio.

Thanks for making this PR! Can you describe the environment you're running where this query fails? cc @mtfriesen

@nibanks nibanks added the Bug: Platform A code bug in platform/TLS specific code. label Feb 4, 2025
@nibanks nibanks merged commit dea6e3d into microsoft:main Feb 5, 2025
480 of 484 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Platform A code bug in platform/TLS specific code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants