Revise the mscclpp datatype #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors data type handling by replacing int parameters with a strongly-typed mscclpp::DataType enum throughout the algorithm API. The changes improve type safety and make the API more self-documenting.
- Introduces
DataTypeenum inexecutor.hppand creates helper functions indatatype.hpp - Updates all algorithm interfaces to use
DataTypeinstead ofint - Adds conversion functions between NCCL and MSCCL++ data types
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/mscclpp/datatype.hpp | New header with utility function for getting data type sizes |
| include/mscclpp/algorithm.hpp | Updated algorithm API signatures to use DataType and fixed documentation typo |
| src/algorithm.cc | Updated implementation to use DataType parameter type |
| apps/nccl/src/datatype_conversion.hpp | New conversion functions between NCCL and MSCCL++ data types |
| apps/nccl/src/nccl.cu | Updated to convert NCCL types to MSCCL++ types before API calls |
| apps/nccl/src/broadcast.hpp | Updated function signatures to use DataType |
| apps/nccl/src/broadcast.cu | Updated implementation with type conversions |
| apps/nccl/src/allreduce.hpp | Updated function signatures to use DataType and added trailing whitespace |
| apps/nccl/src/allreduce.cu | Updated implementation with type conversions and error handling |
| apps/nccl/src/allgather.hpp | Updated function signatures to use DataType |
| apps/nccl/src/allgather.cu | Updated implementation with type conversions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chhwang
requested changes
Nov 7, 2025
Binyang2014
reviewed
Nov 7, 2025
…e difinition of getDataTypeSizer to datype_conversion.hpp
Binyang2014
reviewed
Nov 12, 2025
Binyang2014
approved these changes
Nov 13, 2025
| NumTransports, // The number of transports. | ||
| }; | ||
|
|
||
| /// Data types supported by mscclpp operations. |
Contributor
There was a problem hiding this comment.
How about move to mscclpp/include/mscclpp/gpu_data_types.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mscclpp::DataType to replace the following types in API interface:
int dtype;
ncclDataType_t dtype;
Add data type conversion:
Convert ncclDataType_t to mscclpp::DataType