Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python binding of exceptions #444

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Fix Python binding of exceptions #444

merged 7 commits into from
Jan 9, 2025
+66 −41

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Jan 8, 2025

  • Fixed errors to be catchable from Python code
  • Skip IB tests in Python unit tests when IB ports are down

@chhwang
Copy link
Contributor Author

chhwang commented Jan 8, 2025

/azp run mscclpp-ut

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chhwang chhwang requested a review from Copilot January 8, 2025 06:49
Copilot
Copilot AI reviewed Jan 8, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • include/mscclpp/core.hpp: Language not supported
  • include/mscclpp/executor.hpp: Language not supported
  • include/mscclpp/gpu_utils.hpp: Language not supported
  • include/mscclpp/utils.hpp: Language not supported
  • python/mscclpp/error_py.cpp: Language not supported
  • src/ib.cc: Language not supported
@chhwang
Copy link
Contributor Author

chhwang commented Jan 8, 2025

/azp run mscclpp-ut

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Binyang2014
Binyang2014 approved these changes Jan 9, 2025
View reviewed changes
python/mscclpp/error_py.cpp Show resolved Hide resolved
@chhwang chhwang merged commit f2b52c6 into main Jan 9, 2025
12 checks passed
@chhwang chhwang deleted the chhwang/python-errors branch January 9, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chhwang @Binyang2014