-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Checkbox Consistency #839
Comments
@mdtauk , Please take a look at the comps I uploaded. |
Status update: Reviewed with WinUI team and there was no immediate concern with the design's plan here. Other than obviously the comp is incorrect... |
Status update:Added visual comps |
I am curious as to the thinking behind why the GridView checkbox differs from the other CheckBoxes? In that it uses a background colour, without a border? With a subtle border colour, and a fill you could come up with a single style for Unselected CheckBoxes which would work in Grids, Lists, Trees, Individually and in Groups. |
It is because GridView often gets used with images or tiles as the back drop. Border checkbox will not provide enough visibility to the checkbox. |
Status updateCheckbox consistency detailed design PR with visual change detail is created. |
Status updateSince #953 was approved, doing this change in tandem would ensure system stays intact for coherent design. Reaching out to engineering to ensure this can be done in time. |
Status updateWe were not able to schedule this item in the next release so postponing to future release. #953 will include doing the hover visual update part of checkbox to ensure consistency. |
I have been learning Figma and putting together a WinUI design spec so I can try out ideas and hopefully contribute in a more useful way. I have taken your button spec to heart, with Accent, Filled, Outlined, and Ghost styles for more controls. Looking at the consistency proposal, there seems to be Filled and Outlined styles, so doing full sets of styles/templates for both, and then using the right style for the right use, may be a holistic approach. |
ListViewItem and GridViewItem have to wait for WinUI 3.0, tracking it with #1096. |
Proposal: Make checkbox/radiobutton visuals used around WinUI controls consistent
Checkbox consistency detailed design PR is created.
Summary
As part of looking into the consistency with closer look, we identified inconsistency we unintentionally introduced over the years. To make sure we can move forward as one, we would like to fix this issue so we are not carrying the debt of inconsistency.
Rationale
Scope
*Timing here is not a commitment, but to follow the release cycle. Just using the next version #.
Design details and visuals
This impacts the following controls:
Important Notes
Open Questions
The text was updated successfully, but these errors were encountered: