-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Change Check Box Tick mark to be thicker and look better alongside Indeterminate Checkbox and Radio Button Marks #989
Comments
@jevansaks I understood that proposal to be focused on ensuring the CheckBox used in various WinUI controls, are consistent amongst themselves. Also that the proposed visual comps, continues to use the current MDL2 glyph, with only a change of fontsize where needed. I am happy for this proposal to be rolled into that one, if there is scope to change the checkmark itself. |
I see, yes then I think these should be separate proposals. @chigy do you know if a checkmark glyph update is part of this design update? |
@Poopooracoocoo Is this image better? @shaheedmalik The proposal is only about the design of the checkmark, not the full control - but filled on Checked and Indeterminate states makes sense to me, and fits in with most modern UI approaches from other OSs. Here is the same checkmark applied to the UWP style checkbox states |
I know within the MDL 2 Assets font, there are checkbox glyphs. I see both 16 px and 14 px scaled glyphs, and so I made a quick font with 20px, 16px, and 14px scaled versions of the new checkmark, but rounded to match the upcoming control designs. WinUI.zip |
Thanks for the comments on the FAST check icon. We're actually working right now on switching the checked state to a filled style. That icon will remain the same shape, but will be white over a neutral fill. The indeterminate mode is being updated to a dash more than a square, to further differentiate it from a radio button. It will be unfilled. This coordinates with the platform / user agent changes we've worked on with Chromium, which will be rolling out shortly. |
@bheston could you share the check mark SVG with the Windows team, so the thicker shape can be used in WinUI and Xbox |
Here it is. And the indeterminate one we are updating to. Note that indeterminate will be unfilled, since clicking it in this state toggles it to checked. |
It is true that both Fabric and WinUI are using the same glyph. My point was that I felt the Checkmark used by FastDNA was a better glyph to use. It has a thicker stroke, which fits better with the Indeterminate/ThreeState glyph, as well as the Radio Button glyph. So if adding a new thicker tick mark to the MDL2 font is how this "problem" is solved, then that could be done. |
@mdtauk , yes I understood where you were coming from but I was also commenting on some other feedback about alignment issues. This has to go to both Fabric and Windows design team to see if they want to thicken the tick glyph. Can you please update your proposal to be very clear "Make Tick glyph thicker" or something like that? I can do that, too, if it is agreeable. |
I updated the title - I originally mentioned FastDNA as it, like the Office XAML tick mark, uses a different design, that I assume was approved before appearing, so just making an arbitrary change, might not be deemed appropriate. |
Proposal: Change Check Box Tick mark to be thicker and look better alongside Indeterminate Checkbox and Radio Button Marks
Summary
The Tick glyph used for the CheckBox control can seem a little thin and too close to the edges of the box. FastDNA has the nicest looking version to my eye, compared to the other Microsoft UI frameworks - and I would like to see the others changed to match. The Indeterminate mark and the Checked mark, feel more in balance
Edit: As @chigy suggested, my purpose for asking for a change to the current Tick mark, is because it feels too thin when sat alongside the Intdeterminate mark (whether it is the horizontal line or square mark) as well as the selected Radio Button circle mark. FastDNA's mark works better currently.
FastDNA CheckBox
Fabric Web
XAML UWP
Office UWP
Win32
Material Design - Android
macOS
Important Notes
FastDNA uses an SVG shape, but either the current glyph in the MDL2 font, or a new altered glyph should be added to match the look.
The text was updated successfully, but these errors were encountered: