Update tests for new .NET version and fix ServiceFabricCommandTests#1748
Merged
Update tests for new .NET version and fix ServiceFabricCommandTests#1748
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates test infrastructure to work with newer .NET SDK solution formats and fixes Service Fabric live/recorded test setup so tests execute successfully in the repo’s recorded-test framework.
Changes:
- Update
Test-Code.ps1to locate the generated temporary solution file regardless of.slnvs.slnx. - Fix
ServiceFabricCommandTestsconstructor to includeLiveServerFixtureand pass it toRecordedCommandTestsBase.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ServiceFabric/tests/Azure.Mcp.Tools.ServiceFabric.LiveTests/ServiceFabricCommandTests.cs | Aligns Service Fabric tests with RecordedCommandTestsBase fixture requirements by including LiveServerFixture. |
| eng/scripts/Test-Code.ps1 | Makes temporary solution detection resilient to .sln/.slnx output from newer .NET SDKs. |
msalaman
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Test-Code.ps1 to accommodate the new .NET version by handling solution file creation correctly. Fix issues in ServiceFabricCommandTests to ensure successful execution of tests.
Update a recorded test for Compute- it was earlier comparing the SKU Name of the VMs, but VMs can differ between environments, and not all regions have the same availability for the same SKU etc. So, instead of doing a literal string comparison, we can just check that the property is not null.
GitHub issue number?
N/A
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline