Skip to content

fix: Removing --costs parameter since it was removed in azqr v.3.0.0 (#1738)#1739

Open
cmendible wants to merge 1 commit intomicrosoft:mainfrom
cmendible:update-azqr-command
Open

fix: Removing --costs parameter since it was removed in azqr v.3.0.0 (#1738)#1739
cmendible wants to merge 1 commit intomicrosoft:mainfrom
cmendible:update-azqr-command

Conversation

@cmendible
Copy link
Member

@cmendible cmendible commented Feb 16, 2026

What does this PR do?

This pull request makes a small change to the AzqrCommand execution logic. The default disabling of costs reporting in the Azure Quick Review CLI command has been removed, since version 3.0.0 of the tools removed the flag and disabled costs by default.

  • Removed the line that appended --costs=false to the CLI command.

GitHub issue number?

#1738

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copilot AI review requested due to automatic review settings February 16, 2026 17:55
@cmendible cmendible requested review from a team, jongio and wbreza as code owners February 16, 2026 17:55
@github-actions github-actions bot added the tools-Azd Azure Developer CLI related label Feb 16, 2026
@cmendible cmendible requested a review from a team as a code owner February 16, 2026 17:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the Azure Quick Review (azqr) CLI command integration by removing the --costs=false parameter that was deprecated and removed in azqr version 3.0.0. The change addresses issue #1738 where executing azqr through the MCP server resulted in an error due to the unrecognized flag.

Changes:

  • Removed the line that appended --costs=false to the azqr CLI command, along with its explanatory comment about throttling concerns

Comment on lines 99 to 100
// Also generate a JSON report for users who don't have access to Excel.
command += " --json";
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG.md file needs to be updated to document this bug fix. According to the pre-merge checklist, product changes (bug fixes) must be documented in servers/Azure.Mcp.Server/CHANGELOG.md. This change fixes a bug where the azqr command would fail with version 3.0.0 or higher due to the removed --costs flag. Consider adding an entry under "Bugs Fixed" in the unreleased section documenting this fix and referencing issue #1738.

Copilot uses AI. Check for mistakes.
Comment on lines 99 to 100
// Also generate a JSON report for users who don't have access to Excel.
command += " --json";
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates a backward compatibility concern. Removing the --costs=false flag will cause the azqr command to fail if users have azqr version 2.x or earlier installed (where the flag was still supported). Consider adding a note in the command description or error message indicating that azqr version 3.0.0 or higher is required. Alternatively, you could implement version detection to determine whether to include the flag or handle the error gracefully with a helpful message.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-Azd Azure Developer CLI related

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants

Comments