fix: Removing --costs parameter since it was removed in azqr v.3.0.0 (#1738)#1739
fix: Removing --costs parameter since it was removed in azqr v.3.0.0 (#1738)#1739cmendible wants to merge 1 commit intomicrosoft:mainfrom
Conversation
a71b9f0 to
67e58da
Compare
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the Azure Quick Review (azqr) CLI command integration by removing the --costs=false parameter that was deprecated and removed in azqr version 3.0.0. The change addresses issue #1738 where executing azqr through the MCP server resulted in an error due to the unrecognized flag.
Changes:
- Removed the line that appended
--costs=falseto the azqr CLI command, along with its explanatory comment about throttling concerns
| // Also generate a JSON report for users who don't have access to Excel. | ||
| command += " --json"; |
There was a problem hiding this comment.
The CHANGELOG.md file needs to be updated to document this bug fix. According to the pre-merge checklist, product changes (bug fixes) must be documented in servers/Azure.Mcp.Server/CHANGELOG.md. This change fixes a bug where the azqr command would fail with version 3.0.0 or higher due to the removed --costs flag. Consider adding an entry under "Bugs Fixed" in the unreleased section documenting this fix and referencing issue #1738.
| // Also generate a JSON report for users who don't have access to Excel. | ||
| command += " --json"; |
There was a problem hiding this comment.
This change creates a backward compatibility concern. Removing the --costs=false flag will cause the azqr command to fail if users have azqr version 2.x or earlier installed (where the flag was still supported). Consider adding a note in the command description or error message indicating that azqr version 3.0.0 or higher is required. Alternatively, you could implement version detection to determine whether to include the flag or handle the error gracefully with a helpful message.
What does this PR do?
This pull request makes a small change to the
AzqrCommandexecution logic. The default disabling of costs reporting in the Azure Quick Review CLI command has been removed, since version 3.0.0 of the tools removed the flag and disabled costs by default.--costs=falseto the CLI command.GitHub issue number?
#1738
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline