Add opt-in filtering for hidden XLSX worksheets - #2456
Open
Mingyang Wu (aprylewu) wants to merge 2 commits into
Open
Add opt-in filtering for hidden XLSX worksheets#2456Mingyang Wu (aprylewu) wants to merge 2 commits into
Mingyang Wu (aprylewu) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1073.
XLSX conversion currently includes worksheets marked
hiddenorveryHidden, so content intended to stay out of the visible workbook also appears in Markdown sent to an LLM. The built-in XLSX converter now acceptsinclude_hidden_sheets=Falsethrough the public conversion API:The default still includes every worksheet for compatibility with existing callers. This implements the issue's requested filtering option; changing the default can be considered separately.
Visible worksheets retain their workbook order. Filtering happens before cell parsing, so excluded sheets do not need to be read into DataFrames. The existing repair for legacy
showZeroessheet views preserves the filtering option when retrying. No new dependencies are added.Validation:
pre-commit run --all-filesandgit diff --check: passed.Developed and tested with OpenAI Codex assistance.