Reject UNC and Windows device paths (similar to how netlocks are alre… - #2452
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The security-sensitive path rejection lacks regression tests for supported and rejected URI forms.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Rejects unsafe UNC and Windows device paths during file URI conversion.
Changes:
- Detects Windows network/device path prefixes cross-platform.
- Rejects encoded or normalized unsafe paths.
File summaries
| File | Description |
|---|---|
_uri_utils.py |
Adds unsafe Windows path detection and rejection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+21
to
+22
| decoded_path = unquote_to_bytes(parsed.path).replace(b"\\", b"/") | ||
| if decoded_path.startswith(b"//"): |
Member
Author
There was a problem hiding this comment.
Planned in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject UNC and Windows device paths (similar to how netloc paths are already rejected).