Skip to content

Fix PPTX shape sorting treating top-zero as missing #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afourney merged 2 commits into from
Sep 9, 2026
+4 −4
Merged

Fix PPTX shape sorting treating top-zero as missing #2408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28eee7d
Fix PPTX shape sorting treating top-zero as missing
As9xm Sep 7, 2026
8cd48a2
Merge branch 'main' into fix-pptx-shape-sort-zero-top
afourney Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/markitdown/src/markitdown/converters/_pptx_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ def get_shape_content(shape, **kwargs):
sorted_shapes = sorted(
shape.shapes,
key=lambda x: (
float("-inf") if not x.top else x.top,
float("-inf") if not x.left else x.left,
float("-inf") if x.top is None else x.top,
float("-inf") if x.left is None else x.left,
Comment on lines +192 to +193
),
)
for subshape in sorted_shapes:
Expand All @@ -199,8 +199,8 @@ def get_shape_content(shape, **kwargs):
sorted_shapes = sorted(
slide.shapes,
key=lambda x: (
float("-inf") if not x.top else x.top,
float("-inf") if not x.left else x.left,
float("-inf") if x.top is None else x.top,
float("-inf") if x.left is None else x.left,
),
)
for shape in sorted_shapes:
Expand Down