fix(html): preserve whitespace around anchor text - #2396
Open
IZHAR ALI JAFFAR (Izharalijaffar) wants to merge 1 commit into
Open
fix(html): preserve whitespace around anchor text#2396IZHAR ALI JAFFAR (Izharalijaffar) wants to merge 1 commit into
IZHAR ALI JAFFAR (Izharalijaffar) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML anchor conversion trims text with
chomp(), but several return paths discard the removed whitespace. For example,<p>before<a> middle </a>after</p>currently becomesbeforemiddleafter, losing word boundaries.Preserve the original text when an anchor has no destination, contains only whitespace, or appears inside
<pre>. Include the extracted prefix and suffix when emitting an autolink. Normal links and rejected JavaScript links retain their existing behavior.Adds regression coverage through
MarkItDown.convert_stream()for missing/empty hrefs, named anchors, whitespace-only anchors, preformatted text, and autolinks, plus controls for normal and rejected links.Validation on Windows, Python 3.12.14, markdownify 1.2.3:
test_file_urisandtest_convert_case_insensitive_uri_schemesexpect POSIX paths;test_doc_rlinkattempts to write toC:\tmp\test_rlink.txt. Remote tests were skipped using the suite'sGITHUB_ACTIONSsetting; no live LLM calls were made.pre-commit run --all-files: passed.optionsattribute errors on both original and changed converter; no new errors.Prepared and tested with Codex assistance.