Fix circular import in tools/remote_copy.py #4255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a validate method to check if the given files exist on the the local node. Along with that enable the user to specify `files: ["*"]` in a runbook to upload all the files from the source directory. Signed-off-by: Piyush Sachdeva <psachdeva@microsoft.com> Signed-off-by: Piyush Sachdeva <s.piyush1024@gmail.com>
Instead of checking the existence of the target directory on the destination directly from _internal_run method, do it in a new method: _check_dest_dir, and call this from _internal_run. Signed-off-by: Piyush Sachdeva <psachdeva@microsoft.com> Signed-off-by: Piyush Sachdeva <s.piyush1024@gmail.com.com>
`copy_between_remotes` method does scp of a file[s] (recursively) from source node to destination node. The scp command is executed on the source node. If the destination node is an azure vm, make sure to add the IP address of the source node in the list of `source_address_prefixes` of the destination node for the command to succeed. Signed-off-by: Piyush Sachdeva <psachdeva@microsoft.com> Signed-off-by: Piyush Sachdeva <s.piyush1024@gmail.com>
The new file_transfer transformer uses `copy_between_remotes` method to scp file[s] from source to destination node. Its validate method verifies the existence of files on the source node and also has the functionality to transfer all files from source directory on source node using `files: ["*"]`. In case the `copy_between_remotes` fails, there is also a provision to first save files from source node to local, and then upload from the local node to destination. For this to work, the user should set the `local_path` variable. Signed-off-by: Piyush Sachdeva <psachdeva@microsoft.com> Signed-off-by: Piyush Sachdeva <s.piyush1024@gmail.com>
Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI checker issue related to circular import
Fix circular import in tools/remote_copy.py
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4235 introduced a circular import that broke CI checks. The import chain:
lisa/__init__.py→lisa.environment→lisa.node→lisa.nic→lisa.tools→lisa.tools.remote_copy→ back tolisa.Changes
LisaExceptionfromlisa.utilinstead oflisaintools/remote_copy.pyThis breaks the circular dependency while maintaining identical functionality.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.