New testcase 'verify_smb_linux' by SRIKKANTH · Pull Request #4184 · microsoft/lisa

SRIKKANTH · 2026-01-02T20:00:38Z

A comprehensive test to verify CIFS module and SMB share functionality between two Linux VMs.

SRIKKANTH · 2026-01-02T20:07:48Z

Depended on PR #4182

New testcase 'verify_smb_linux' A comprehensive test to verify CIFS module and SMB share functionality between two Linux VMs.

Copilot

Pull request overview

This PR adds a new test case verify_smb_linux to validate CIFS module and SMB share functionality between two Linux VMs. The test creates two VMs in Azure, configures one as an SMB server and the other as a client, then validates SMB mounting and file I/O operations across multiple SMB versions (2.0, 2.1, 3.0, 3.1.1).

Critical Issue: The test cannot execute as written because it depends on SmbClient and SmbServer tools that do not exist in the codebase. These tools must be implemented before the test can be functional.

Key Changes

Adds comprehensive SMB/CIFS testing between two Linux VMs
Tests multiple SMB protocol versions (2.0, 2.1, 3.0, 3.1.1)
Validates bidirectional file I/O through SMB shares

lisa/microsoft/testsuites/core/storage.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…com/microsoft/lisa into smyakam/verify_smb_linux/03_01_2025

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adityagesh · 2026-01-05T04:13:00Z

lisa/microsoft/testsuites/core/storage.py

+        timeout=TIME_OUT,
+        requirement=simple_requirement(
+            min_count=2,
+            unsupported_os=[Redhat, CBLMariner, AlmaLinux, BSD, Windows],


Why is Redhat, CBLMariner and Alma unsupported?
In the SMBTool, the below line exists

if isinstance(self.node.os, (CBLMariner, Redhat, Fedora, Oracle, Suse)):

SMB "server" packages are not officially supported by Mariner. Redhat family have issues SELinux etc.
Only Ubuntu, Debian and SUSE are supported for this test case now.

Only Ubuntu, Debian and SUSE are supported for this test case now.

Do you want to rather use supported_os requirement in that case?

Redhat has issues because of SELinux, we can't make it work in test code?
Do we have a link for SMB "server" packages are not officially supported by Mariner

adityagesh · 2026-01-05T04:14:24Z

lisa/microsoft/testsuites/core/storage.py

+                smb_client.unmount_share(mount_point)
+            smb_client.cleanup_mount_point(mount_point)
+        except Exception as e:
+            log.warning(


Dont use warning

changed to "log.error()"

Use log.info or log.debug. If you need to exit, you can raise an Exception

adityagesh · 2026-01-05T04:14:52Z

lisa/microsoft/testsuites/core/storage.py

+            smb_server.stop()
+            smb_server.remove_share(share_path)
+        except Exception as e:
+            log.warning(


Dont use warning

changed to "log.error()"

adityagesh · 2026-01-05T04:15:03Z

lisa/microsoft/testsuites/core/storage.py

+            smb_server = server_node.tools[SmbServer]
+            smb_server.stop()
+            smb_server.remove_share(share_path)
+        except Exception as e:


If cleanup fails, mark node as dirty

Fixed as suggested.

added comment below

lisa/microsoft/testsuites/core/storage.py

adityagesh · 2026-01-05T04:20:32Z

lisa/microsoft/testsuites/core/storage.py

+            smb_server.create_share(share_name, share_path)
+
+            # Step 8: Repeat for different SMB versions
+            for smb_version in smb_versions:


In the current logic, if one version fails, the case fails and exits.
Is that the expected? or do you want to verify each version independently?

lisa/microsoft/testsuites/core/storage.py

adityagesh · 2026-01-05T04:27:26Z

lisa/microsoft/testsuites/core/storage.py

+        for role_name, role_node in (("server", server_node), ("client", client_node)):
+            if not role_node.tools[KernelConfig].is_enabled("CONFIG_CIFS"):
+                raise LisaException(
+                    f"CIFS module must be present for SMB testing on {role_name} node"


Since we are not printing the node being assigned as server and client, printing the role_name does not add value in the logging.
Do you rather want to print the node name? or I think it's fine to just have it like "CIFS module must be present on the node", as both nodes are identical

Since both the nodes are identical its okay this way.

In that case "{role_name}" does not add any value in the logging statement, you can replace it with "CIFS module must be present" ?

lisa/microsoft/testsuites/core/storage.py

LiliDeng · 2026-01-05T04:59:18Z

@SRIKKANTH please make the two PRs into one PR, so that we can validate it.

SMB server and client tools These tools are useful in validating samba file share with Linux OS and CIFS module in kernel.

SRIKKANTH · 2026-01-05T10:58:32Z

@SRIKKANTH please make the two PRs into one PR, so that we can validate it.

Merged both PRs.

adityagesh · 2026-01-06T07:12:31Z

lisa/microsoft/testsuites/core/storage.py

+            )
+            bad_cleanup = True
+        if bad_cleanup:
+            raise BadEnvironmentStateException("SMB test cleanup encountered errors.")


raising BadEnvironmentStateException in the case will cause test case failure.

You are running the cleanup in the case itself, hence even if your test logic succeeds, but the cleanup fails, the case will fail.

You can move the cleanup to after case, or ensure that cleanup does not raise an Exception within the case.
If you are moving the cleanup to after case, use self.node.mark_dirty() because BadEnvironmentStateException does not mark the env as dirty in after case

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

Copilot · 2026-01-08T06:00:39Z

lisa/tools/smb.py

+        # Install client utilities
+        if isinstance(
+            self.node.os,
+            (Ubuntu, Debian, CBLMariner, CoreOs, Fedora, Oracle, Redhat, Suse, Alpine),


The _install method for SmbClient includes CBLMariner in the supported distributions list, but the test case excludes CBLMariner in its requirements (line 624 of storage.py). This creates an inconsistency in which distributions are actually supported for SMB client functionality.

Suggested change

(Ubuntu, Debian, CBLMariner, CoreOs, Fedora, Oracle, Redhat, Suse, Alpine),

(Ubuntu, Debian, CoreOs, Fedora, Oracle, Redhat, Suse, Alpine),

Copilot · 2026-01-08T06:00:39Z

lisa/tools/smb.py

+        mount_options = [
+            f"vers={smb_version}",
+            "file_mode=0777",
+            "dir_mode=0777",
+            "guest",
+        ]
+


The mount options use hardcoded permissions (file_mode=0777, dir_mode=0777) which create a security risk. Consider making these configurable via the options parameter or using more restrictive defaults like 0755.

Suggested change

mount_options = [

f"vers={smb_version}",

"file_mode=0777",

"dir_mode=0777",

"guest",

]

mount_options: List[str] = [

f"vers={smb_version}",

"guest",

]

# Apply default permissions only if not specified by caller

caller_options = options or []

if not any(opt.startswith("file_mode=") for opt in caller_options):

mount_options.append("file_mode=0755")

if not any(opt.startswith("dir_mode=") for opt in caller_options):

mount_options.append("dir_mode=0755")

lisa/microsoft/testsuites/core/storage.py

Copilot · 2026-01-08T06:00:40Z

lisa/microsoft/testsuites/core/storage.py

+            unsupported_os=[Redhat, CBLMariner, AlmaLinux, BSD, Windows],
+        ),


The test excludes Redhat, CBLMariner, and AlmaLinux from the supported_os list, but there's no clear documentation explaining why these distributions are unsupported. Consider adding a comment explaining the technical reason (e.g., package availability issues, known bugs, or version compatibility problems) to help future maintainers understand this decision.

Copilot · 2026-01-08T06:00:40Z

lisa/tools/smb.py

+        elif isinstance(self.node.os, (Debian, CoreOs, Fedora, Oracle, Redhat, Suse)):
+            self.node.os.install_packages(["samba", "cifs-utils"])


The _install method includes CBLMariner in the installation logic, but the test case explicitly excludes CBLMariner in its requirements (line 624 of storage.py). Either CBLMariner should be removed from this installation list to match the test requirements, or the test should support CBLMariner. This inconsistency could lead to confusion about which distributions are actually supported.

lisa/tools/smb.py

Copilot · 2026-01-08T06:00:41Z

lisa/tools/smb.py

+        # Set permissions for the share directory
+        self.node.tools[Chmod].chmod(share_path, "777", sudo=True)


Setting directory permissions to 777 creates a security risk by allowing any user to read, write, and execute files in the share directory. While this might be acceptable for testing purposes, consider using more restrictive permissions (e.g., 755 or 775) and document the security implications, especially if this code could be used as a reference for production setups.

Suggested change

# Set permissions for the share directory

self.node.tools[Chmod].chmod(share_path, "777", sudo=True)

# Set permissions for the share directory.

# Use 775 to avoid world-writable permissions (777) while still

# allowing group members to write to the share directory.

self.node.tools[Chmod].chmod(share_path, "775", sudo=True)

lisa/tools/smb.py

SRIKKANTH requested a review from LiliDeng as a code owner January 2, 2026 20:00

New testcase 'verify_smb_linux'

4ac2dad

New testcase 'verify_smb_linux' A comprehensive test to verify CIFS module and SMB share functionality between two Linux VMs.

SRIKKANTH force-pushed the smyakam/verify_smb_linux/03_01_2025 branch from cfb9c2e to 4ac2dad Compare January 2, 2026 20:20

LiliDeng requested a review from Copilot January 4, 2026 03:15

Copilot started reviewing on behalf of LiliDeng January 4, 2026 03:16 View session

Copilot AI reviewed Jan 4, 2026

View reviewed changes

SRIKKANTH and others added 8 commits January 4, 2026 18:19

Update lisa/microsoft/testsuites/core/storage.py

7298e22

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lisa/microsoft/testsuites/core/storage.py

a9cd407

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update storage.py

795afb9

Update lisa/microsoft/testsuites/core/storage.py

7418886

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update storage.py

cb9cdce

Merge branch 'smyakam/verify_smb_linux/03_01_2025' of https://github.…

efe4ed5

…com/microsoft/lisa into smyakam/verify_smb_linux/03_01_2025

Update lisa/microsoft/testsuites/core/storage.py

52d1384

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update storage.py

b75577f

SRIKKANTH mentioned this pull request Jan 5, 2026

SMB server and client tools #4182

Closed

adityagesh reviewed Jan 5, 2026

View reviewed changes

lisa/microsoft/testsuites/core/storage.py Show resolved Hide resolved

adityagesh reviewed Jan 5, 2026

View reviewed changes

lisa/microsoft/testsuites/core/storage.py Outdated Show resolved Hide resolved

adityagesh reviewed Jan 5, 2026

View reviewed changes

lisa/microsoft/testsuites/core/storage.py Outdated Show resolved Hide resolved

SRIKKANTH added 4 commits January 5, 2026 13:23

SMB server and client tools

c8c96f5

SMB server and client tools These tools are useful in validating samba file share with Linux OS and CIFS module in kernel.

Update storage.py

ec2e1c9

Update storage.py

626bed6

Update smb.py

b8c1aef

SRIKKANTH added 2 commits January 5, 2026 14:09

Update storage.py

259e3c3

Update storage.py

b58aa41

adityagesh reviewed Jan 6, 2026

View reviewed changes

LiliDeng requested a review from Copilot January 8, 2026 05:56

Copilot started reviewing on behalf of LiliDeng January 8, 2026 05:57 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

	(Ubuntu, Debian, CBLMariner, CoreOs, Fedora, Oracle, Redhat, Suse, Alpine),
	(Ubuntu, Debian, CoreOs, Fedora, Oracle, Redhat, Suse, Alpine),

		unsupported_os=[Redhat, CBLMariner, AlmaLinux, BSD, Windows],
		),

		elif isinstance(self.node.os, (Debian, CoreOs, Fedora, Oracle, Redhat, Suse)):
		self.node.os.install_packages(["samba", "cifs-utils"])

		# Set permissions for the share directory
		self.node.tools[Chmod].chmod(share_path, "777", sudo=True)

-        # Set permissions for the share directory
-        self.node.tools[Chmod].chmod(share_path, "777", sudo=True)
+        # Set permissions for the share directory.
+        # Use 775 to avoid world-writable permissions (777) while still
+        # allowing group members to write to the share directory.
+        self.node.tools[Chmod].chmod(share_path, "775", sudo=True)

Conversation

SRIKKANTH commented Jan 2, 2026

Uh oh!

SRIKKANTH commented Jan 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityagesh Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adityagesh Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adityagesh Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LiliDeng commented Jan 5, 2026

Uh oh!

SRIKKANTH commented Jan 5, 2026

Uh oh!

adityagesh Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

adityagesh Jan 6, 2026 •

edited

Loading

adityagesh Jan 5, 2026 •

edited

Loading

adityagesh Jan 5, 2026 •

edited

Loading

adityagesh Jan 6, 2026 •

edited

Loading