Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/go package name casing #4688

Merged
merged 10 commits into from
May 21, 2024
Merged

Fix/go package name casing #4688

merged 10 commits into from
May 21, 2024

Conversation

SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented May 20, 2024 •
edited
Loading

This is work in progress and might be rewritten.

@SilasKenneth SilasKenneth self-assigned this May 20, 2024
@SilasKenneth SilasKenneth linked an issue May 20, 2024 that may be closed by this pull request
Issue with package names being converted from UpperCamel case to LowerCamel case. #4498
Closed
@SilasKenneth SilasKenneth marked this pull request as ready for review May 21, 2024 09:24
@SilasKenneth SilasKenneth requested a review from a team as a code owner May 21, 2024 09:24
andrueastman
andrueastman reviewed May 21, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add a test to validate the change?

@SilasKenneth
Copy link
Member Author

Any chance we can add a test to validate the change?

Done @andrueastman

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SilasKenneth SilasKenneth merged commit 8c953fb into main May 21, 2024
207 checks passed
@SilasKenneth SilasKenneth deleted the fix/go-package-name-casing branch May 21, 2024 14:20
@rkodev rkodev mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees

@SilasKenneth SilasKenneth

Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with package names being converted from UpperCamel case to LowerCamel case.
3 participants
@SilasKenneth @andrueastman @baywet