-
Notifications
You must be signed in to change notification settings - Fork 4
feat/azure identity #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
4137b61
to
b58c25c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only important suggestions would be custom http client wrapper and small Dart-specific stuff
packages/microsoft_kiota_azure/lib/src/azure_authentication_provider.dart
Outdated
Show resolved
Hide resolved
packages/microsoft_kiota_azure/lib/src/device_code_token_error.dart
Outdated
Show resolved
Hide resolved
packages/microsoft_kiota_azure/lib/src/device_code_token_response.dart
Outdated
Show resolved
Hide resolved
packages/microsoft_kiota_azure/lib/src/token_request_context.dart
Outdated
Show resolved
Hide resolved
packages/microsoft_kiota_azure/lib/src/token_request_context.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/microsoft_kiota_azure/lib/src/azure_access_token_provider.dart
Outdated
Show resolved
Hide resolved
packages/microsoft_kiota_azure/lib/src/azure_authentication_provider.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Musale Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes 👍🏼
partial #69