jobcontainers: wire Windows CPU affinity to JobObject limits#2603
Open
wenyang wants to merge 1 commit intomicrosoft:mainfrom
Open
jobcontainers: wire Windows CPU affinity to JobObject limits#2603wenyang wants to merge 1 commit intomicrosoft:mainfrom
wenyang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Signed-off-by: Weyang1 <weyang1@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specToLimits).JobLimitswithCPUAffinityand apply it inSetResourceLimitsviaSetCPUAffinity.Motivation
This is the Phase 1 quick-win for Windows CPU affinity: unblock HostProcess pod scenarios that run through the JobContainer/JobObject path.
Scope
internal/jobcontainers/oci.gointernal/jobcontainers/oci_test.gointernal/jobobject/jobobject.gointernal/jobobject/limits.gointernal/jobobject/jobobject_test.goBehavior
windows.resources.cpu.affinityis specified as a single entry withgroup=0and non-zeromask, affinity is applied to the job object.Limitations (intentional for Phase 1)
Processorschema affinity support is not part of this PR (Phase 2).Testing
TestSpecToLimits_CPUAffinity_Group0MaskSetTestSpecToLimits_CPUAffinity_MultiGroupRejectedTestSpecToLimits_CPUAffinity_NonZeroGroupRejectedTestSpecToLimits_CPUAffinity_ZeroMaskRejectedTestSetResourceLimitsCPUAffinityGOOS=windows go test ./internal/jobcontainers ./internal/jobobject -count=1 -v