allow httpx 0.27 #1594
Open
allow httpx 0.27 #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of the libraries in the python ecosystem are still locked on 0.27, creating all kind of dependency conflicts. As far as I could tell by overriding the version locally, there should not be any reason for GraphRAG to require httpx version 0.28.
I was wondering if it would be possible to make the requirements of httpx less strict for GraphRAG
Proposed Changes
Allow version 0.27.X and 0.28.X version of httpx.
Checklist
Additional Notes
I ran
poetry run poe test_unitbut did not ran the integration or smoke tests because of the requirement for a OPENAI_API_KEY and GRAPHRAG_API_KEY.