scalar: add --<verb>-cache-server-url options#849
Merged
dscho merged 2 commits intomicrosoft:vfs-2.53.0from Feb 11, 2026
Merged
scalar: add --<verb>-cache-server-url options#849dscho merged 2 commits intomicrosoft:vfs-2.53.0from
dscho merged 2 commits intomicrosoft:vfs-2.53.0from
Conversation
derrickstolee
force-pushed
the
scalar-gvfs-verb
branch
from
7e1cb1e to
dbc9880
Compare
In git#836, we implemented custom gvfs.<verb>.cache-server config options that allow existing enlistments to point specific GVFS Protocol verbs at different cache servers. However, that did not help at clone time. This change adds --<verb>-cache-server-url options to 'scalar clone' to allow initial clones to take advantage of different cache servers. The intended use here is to take advantage of new cache server infrastructure as each protocol endpoint is deployed independently. Signed-off-by: Derrick Stolee <stolee@gmail.com>
derrickstolee
force-pushed
the
scalar-gvfs-verb
branch
from
dbc9880 to
e34ed6e
Compare
derrickstolee
force-pushed
the
scalar-gvfs-verb
branch
2 times, most recently
from
25385e8 to
325951e
Compare
derrickstolee
force-pushed
the
scalar-gvfs-verb
branch
from
325951e to
513edb4
Compare
Now that we are testing the --<verb>-cache-server options in t9210, we need to be more careful about our variable names to ensure those created in t9210-scalar.sh are different from those set in lib-gvfs-helper.sh. For this we: * Rename variables to use ORIGIN_* for those that host Git repo data. * Update server output files to have more specific names. * Avoid using the default test server port when possible, in preference for a positive shift-by-10k. Signed-off-by: Derrick Stolee <stolee@gmail.com>
derrickstolee
force-pushed
the
scalar-gvfs-verb
branch
from
513edb4 to
3c035ee
Compare
dscho
approved these changes
Feb 11, 2026
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
Just one suggestion, but that can easily be a follow-up instead of holding up this here PR.
| ' | ||
|
|
||
| test_expect_success 'fetch <non-existent> does not hang in gvfs-helper' ' | ||
| test_expect_success EXPENSIVE 'fetch <non-existent> does not hang in gvfs-helper' ' |
Member
There was a problem hiding this comment.
Do we want to use a special prereq here that tests for either GIT_TEST_LONG or another variable that we then set in our CI, so that this test case is exercised in the CI builds?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #836, we implemented custom gvfs..cache-server config options that allow existing enlistments to point specific GVFS Protocol verbs at different cache servers. However, that did not help at clone time.
This change adds ---cache-server-url options to 'scalar clone' to allow initial clones to take advantage of different cache servers.
The intended use here is to take advantage of new cache server infrastructure as each protocol endpoint is deployed independently.
GVFS Protocol.