Support SELECT inside multi-exec #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the SELECT command within multi-exec transactions and fixes issue #715. It includes a new test case for transaction execution and updates the transaction key manager to recognize the SELECT command.
- Adds a new test method TxnExecuteTest in TransactionTests.cs to verify multi-exec behavior.
- Updates TxnKeyManager.cs to map the SELECT command correctly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Garnet.test/TransactionTests.cs | Adds new test TxnExecuteTest for multi-exec transactions |
| libs/server/Transaction/TxnKeyManager.cs | Extends command mapping to support SELECT |
Comments suppressed due to low confidence (1)
test/Garnet.test/TransactionTests.cs:62
- While the PR title focuses on SELECT support inside multi-exec, there is no test case that exercises the SELECT command. Consider adding a dedicated test that verifies the behavior of SELECT in a multi-exec transaction.
[Test]
TalZaccai
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support SELECT inside multi-exec
Fixes #715