fix(web-components): quirks when utilizing DSD#35838
Draft
radium-v wants to merge 2 commits intomicrosoft:masterfrom
Draft
fix(web-components): quirks when utilizing DSD#35838radium-v wants to merge 2 commits intomicrosoft:masterfrom
radium-v wants to merge 2 commits intomicrosoft:masterfrom
Conversation
…lue and ariaSelected
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 3154 | Changed |
vr-tests-web-components/MenuList 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 498 | Changed |
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium_3.png | 38816 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.1st selected.chromium_2.png | 119 | Changed |
mohamedmansour
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
selectedsetter in the DropdownOption component checkedthis.$fastController.isConnectedbefore setting form value and aria attributes. This condition could pass even whenelementInternalswas not yet available, potentially causing errors when attempting to callsetFormValue()or setariaSelected.New Behavior
The condition now checks for
this.elementInternalsdirectly before setting form value and aria attributes. This ensures these operations only occur whenelementInternalsis properly initialized and available.This change is needed in scenarios which use declarative Shadow DOM, where the
constructor()andconnectedCallback()can happen simultaneously. Since everything happening in this block only requireselementInternalsto be defined, and doesn't rely on the element being connected, it can safely be handled with the next tick regardless of the connected state.