Skip to content

fix(react-motion): remove @internal from MotionRefForwarder exports #35828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
layershifter wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(react-motion): remove @internal from MotionRefForwarder exports #35828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1b8dce
fix(react-motion): remove @internal from MotionRefForwarder exports
layershifter Mar 3, 2026
875ac5a
chore: add change file
layershifter Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-motion-89bb8fb3-4812-410f-917b-8cec04303309.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link

@github-actions github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png 6 Changed
vr-tests-react-components/Charts-DonutChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png 5570 Changed
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png 413 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 616 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 145 Changed
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Skeleton converged.Opaque Skeleton with square - Dark Mode.default.chromium.png 2 Changed
vr-tests-react-components/TagPicker 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - RTL.chromium.png 635 Changed
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png 658 Changed
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png 677 Changed

There were 3 duplicate changes discarded. Check the build logs for more information.

"type": "patch",
"comment": "fix: remove @internal from MotionRefForwarder exports",
"packageName": "@fluentui/react-motion",
"email": "olfedias@microsoft.com",
"dependentChangeType": "patch"
}
6 changes: 3 additions & 3 deletions packages/react-components/react-motion/library/etc/react-motion.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ export type MotionImperativeRef = {
// @public
export type MotionParam = boolean | number | string;

// @internal
// @public
export const MotionRefForwarder: React_2.ForwardRefExoticComponent<{
children?: React_2.ReactElement;
} & React_2.RefAttributes<HTMLElement>>;

// @internal
// @public
export const MotionRefForwarderReset: React_2.FC<{
children: React_2.ReactElement;
}>;
Expand Down Expand Up @@ -189,7 +189,7 @@ export type PresenceMotionSlotProps<MotionParams extends Record<string, MotionPa
}>;
};

// @internal
// @public
export function useMotionForwardedRef(): React_2.Ref<HTMLElement> | undefined;

// @public (undocumented)
Expand Down
6 changes: 0 additions & 6 deletions packages/react-components/react-motion/library/src/components/MotionRefForwarder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ const MotionRefForwarderContext = React.createContext<React.Ref<HTMLElement> | u
/**
* A hook that reads the ref forwarded by `MotionRefForwarder` from context.
* Used in child components to merge the motion ref into the root slot ref.
*
* @internal
*/
export function useMotionForwardedRef(): React.Ref<HTMLElement> | undefined {
return React.useContext(MotionRefForwarderContext);
Expand All @@ -18,8 +16,6 @@ export function useMotionForwardedRef(): React.Ref<HTMLElement> | undefined {
* A component that forwards a ref to its children via a React context.
* This is used to pass a motion component's ref through to the actual surface element,
* since motion components wrap their children and the ref needs to reach the inner element.
*
* @internal
*/
export const MotionRefForwarder = React.forwardRef<HTMLElement, { children?: React.ReactElement }>((props, ref) => {
return <MotionRefForwarderContext.Provider value={ref}>{props.children}</MotionRefForwarderContext.Provider>;
Expand All @@ -31,8 +27,6 @@ MotionRefForwarder.displayName = 'MotionRefForwarder';
* Resets the MotionRefForwarder context to `undefined` for its children.
* Render this in components that consume `useMotionForwardedRef()` and render
* arbitrary user content, to prevent the context from leaking to descendants.
*
* @internal
*/
export const MotionRefForwarderReset: React.FC<{ children: React.ReactElement }> = props => {
return <MotionRefForwarderContext.Provider value={undefined}>{props.children}</MotionRefForwarderContext.Provider>;
Expand Down