feat(react-field): add useFieldBase_unstable hook#35827
Draft
dmytrokirpa wants to merge 4 commits intomasterfrom
Draft
feat(react-field): add useFieldBase_unstable hook#35827dmytrokirpa wants to merge 4 commits intomasterfrom
dmytrokirpa wants to merge 4 commits intomasterfrom
Conversation
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
Implements base state hook for Field component as part of the experimental base hooks initiative. The base hook extracts pure component logic while omitting design props (orientation, size). - FieldBaseProps: omits orientation, size - FieldBaseState: omits orientation, size - useFieldBase_unstable: handles - validationState with role="alert" for error/warning messages - ID generation (baseId, generatedControlId) for form control association - label slot with htmlFor, id, required - validationMessage slot with id, role - hint slot with id - validationMessageIcon slot with appropriate icon based on validationState - slot structure (root, label, validationMessage, validationMessageIcon, hint) useField_unstable now calls useFieldBase_unstable and adds orientation, size design props. The size prop is merged into the label slot's props. All new types and hooks exported from package index.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
force-pushed
the
feat/react-field-base-hooks
branch
from
013b527 to
6a809a3
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 609 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 507 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - High Contrast.default.chromium.png | 1 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a base state hook for the Field component as part of the experimental base hooks initiative.
What was implemented
useFieldBase_unstable— base hook forFieldcomponentFieldBaseProps(omitsorientation,size)FieldBaseState(omitsorientation,size)validationStatedefaulting ('error'whenvalidationMessageis set,'none'otherwise)role="alert"on validationMessage forerrorandwarningstatesuseId) for form control association (generatedControlId)htmlFor,id,requiredpropsidandroleidErrorCircle12Filled,Warning12Filled,CheckmarkCircle12Filled, or none)root,label,validationMessage,validationMessageIcon,hint)Note on
sizeThe
sizeprop controls the label's size. InuseField_unstable, after callinguseFieldBase_unstable, thesizevalue is merged into the label slot's props.orientationis added directly to the returned state object.Exports
All new types and hooks are exported from the package
index.ts. They are NOT exported from@fluentui/react-components.Test plan
npx tsc --noEmiton the package)htmlFor🤖 Generated with Claude Code