feat(react-search): add useSearchBoxBase_unstable hook#35825
Draft
dmytrokirpa wants to merge 3 commits intomasterfrom
Draft
feat(react-search): add useSearchBoxBase_unstable hook#35825dmytrokirpa wants to merge 3 commits intomasterfrom
dmytrokirpa wants to merge 3 commits intomasterfrom
Conversation
Implements useSearchBoxBase_unstable hook for the SearchBox component that extracts pure component logic (controlled/uncontrolled value state, focus tracking, dismiss button click handling, search icon slot, type=search input) without design props (size, appearance). The styled hook useSearchBox_unstable now delegates to the base hook and adds size and appearance. Adds SearchBoxBaseProps and SearchBoxBaseState types using DistributiveOmit, omitting appearance and size from SearchBoxProps/SearchBoxState. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
force-pushed
the
feat/react-search-base-hooks
branch
from
6e2444a to
9e468a9
Compare
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 609 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 497 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchBoxBase_unstablehook that extracts the core SearchBox logic without design props (size,appearance)SearchBoxBasePropsandSearchBoxBaseStatetypes usingDistributiveOmituseSearchBox_unstableto delegate to the base hook, then addsizeandappearanceindex.ts, barrel file, and packageindex.tsWhat the base hook manages
useControllableState)focusedstate,onFocus/onBlurcallbacks viasearchBoxRootRef)onChange, restores focus)type="search"input viauseInput_unstablecontentBeforewithSearchRegulardefault)role="button"andaria-label="clear"Design props excluded from base hook
size'small'/'medium'/'large'input sizeappearance'outline'/'underline'/'filled-darker'/ etc.Test plan
npx tsc -p packages/react-components/react-search/library/tsconfig.json --noEmit)useSearchBoxBase_unstableis exported from the package index🤖 Generated with Claude Code