feat(react-textarea): add useTextareaBase_unstable hook#35822
Draft
dmytrokirpa wants to merge 2 commits intomasterfrom
Draft
feat(react-textarea): add useTextareaBase_unstable hook#35822dmytrokirpa wants to merge 2 commits intomasterfrom
dmytrokirpa wants to merge 2 commits intomasterfrom
Conversation
Adds a base state hook for Textarea component that extracts pure component logic (slot structure, controlled/uncontrolled value state) without design-related props (appearance, size). - Add TextareaBaseProps type omitting appearance and size (design props) - Add TextareaBaseState type omitting appearance and size - Add useTextareaBase_unstable hook that handles: - Slot setup (root and textarea slots) - Controlled/uncontrolled value state via useControllableState - onChange callback management - Field integration via useFieldControlProps_unstable - resize structural prop (controls how users can resize the textarea) - Refactor useTextarea_unstable to call useTextareaBase_unstable internally - Export new types and hook from package index.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
force-pushed
the
feat/react-textarea-base-hooks
branch
from
dc33de9 to
472fc0b
Compare
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
vr-tests-react-components/Field 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Field.Textarea+horizontal.default.chromium.png | 2696 | Changed |
| vr-tests-react-components/Field.Textarea.default.chromium.png | 3543 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 605 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 514 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useTextareaBase_unstablehook toreact-textareathat extracts pure component logic without design propsTextareaBasePropstype omittingappearanceandsize(design-related props);resizeis kept as it is a structural/behavioral prop controlling how users can resize the textareaTextareaBaseStatetype omittingappearanceandsizeuseTextarea_unstableto calluseTextareaBase_unstableinternallyindex.tsWhat base hooks include
The base hook preserves:
rootspan wrapper andtextareaelement slots)resizestructural prop (controls textarea resize behavior)useControllableStateonChangecallback with typed datauseFieldControlProps_unstableThe base hook excludes:
appearanceprop (outline/filled-darker/filled-lighter variants - design concern)sizeprop (small/medium/large - design concern)Test plan
useTextareaBase_unstablecan be imported from@fluentui/react-textareaTextareaBasePropsandTextareaBaseStatetypes are exporteduseTextarea_unstablebehavior is unchanged🤖 Generated with Claude Code