feat(react-switch): add useSwitchBase_unstable hook#35820
Draft
dmytrokirpa wants to merge 1 commit intomasterfrom
Draft
feat(react-switch): add useSwitchBase_unstable hook#35820dmytrokirpa wants to merge 1 commit intomasterfrom
dmytrokirpa wants to merge 1 commit intomasterfrom
Conversation
0f5ed9f to
3a4afe0
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSwitchBase_unstablehook inreact-switchuseSwitchBase_unstablehook from the packageindex.tsSwitchBasePropsandSwitchBaseStatetypes from the packageindex.tsThe implementation was already present on the experimental branch (added in an earlier commit) but the exports were commented out with a note "Experimental APIs - will be uncommented in experimental branch". This PR enables those exports.
What the base hook includes
useSwitchBase_unstablemanages:root,indicator,input,labelslots)role="switch"ARIA attribute on inputlabelPositionstructural propuseFocusWithinuseFieldControlProps_unstableonChangecallback with typed datauseSwitchBase_unstableexcludes:sizeprop (small/medium - design concern)Test plan
useSwitchBase_unstablecan be imported from@fluentui/react-switchSwitchBasePropsandSwitchBaseStatetypes are exporteduseSwitch_unstablebehavior is unchanged🤖 Generated with Claude Code