feat(react-spinner): add useSpinnerBase_unstable hook#35818
Draft
dmytrokirpa wants to merge 3 commits intomasterfrom
Draft
feat(react-spinner): add useSpinnerBase_unstable hook#35818dmytrokirpa wants to merge 3 commits intomasterfrom
dmytrokirpa wants to merge 3 commits intomasterfrom
Conversation
Adds a base state hook for Spinner component that extracts pure component logic (ARIA, slot structure, delay-based visibility) without design-related props (appearance, size). - Add SpinnerBaseProps type omitting appearance and size (design props) - Add SpinnerBaseState type omitting appearance and size - Add useSpinnerBase_unstable hook preserving: - role=progressbar ARIA attribute - aria-labelledby association with label slot - delay-based visibility logic (shouldRenderSpinner) - labelPosition structural prop - All slot setup (root, spinner, spinnerTail, label) - Refactor useSpinner_unstable to call useSpinnerBase_unstable internally - Export new types and hook from package index.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
dmytrokirpa
force-pushed
the
feat/react-spinner-base-hooks
branch
from
a02567c to
aa43e92
Compare
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 131 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 497 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.chromium.png | 677 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSpinnerBase_unstablehook toreact-spinnerthat extracts pure component logic without design propsSpinnerBasePropstype omittingappearanceandsize(design-related props)SpinnerBaseStatetype omittingappearanceandsizeuseSpinner_unstableto calluseSpinnerBase_unstableinternallyindex.tsWhat base hooks include
The base hook preserves:
role="progressbar"ARIA attributearia-labelledbyassociation linking root to label slotdelaybehavioral prop (controls when spinner becomes visible)shouldRenderSpinnerderived state (delay-based visibility logic)labelPositionstructural prop (determines slot layout)root,spinner,spinnerTail,labelThe base hook excludes:
appearanceprop (primary/inverted - design concern)sizeprop (extra-tiny through huge - design concern)Test plan
useSpinnerBase_unstablecan be imported from@fluentui/react-spinnerSpinnerBasePropsandSpinnerBaseStatetypes are exporteduseSpinner_unstablebehavior is unchangeddelayprop still controls spinner visibility correctly via base hookaria-labelledbyis set correctly when label is provided🤖 Generated with Claude Code