feat(react-progress): add useProgressBarBase_unstable hook#35817
Draft
dmytrokirpa wants to merge 3 commits intomasterfrom
Draft
feat(react-progress): add useProgressBarBase_unstable hook#35817dmytrokirpa wants to merge 3 commits intomasterfrom
dmytrokirpa wants to merge 3 commits intomasterfrom
Conversation
Implements useProgressBarBase_unstable hook that extracts the core ARIA progressbar logic (role=progressbar, aria-valuemin/max/valuenow, field context integration) without design props (shape, thickness, color). The styled hook useProgressBar_unstable now delegates to the base hook and adds design-specific state. Adds ProgressBarBaseProps and ProgressBarBaseState types derived from ProgressBarProps/ ProgressBarState using DistributiveOmit, omitting shape, thickness, and color. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
force-pushed
the
feat/react-progress-base-hooks
branch
from
87ed181 to
e86cd02
Compare
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
vr-tests-react-components/Charts-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 723 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 607 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - RTL.chromium.png | 635 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useProgressBarBase_unstablehook that extracts pure ProgressBar logic: ARIArole=progressbar,aria-valuemin,aria-valuemax,aria-valuenow, field context integration (aria-labelledby,aria-describedby), value clampingProgressBarBasePropsandProgressBarBaseStatetypes usingDistributiveOmituseProgressBar_unstableto delegate to the base hook, then add design propsindex.tsand packageindex.tsDesign props excluded from base hook
shape'rounded'or'square'bar shapethickness'medium'or'large'bar thicknesscolor'brand'/'success'/'warning'/'error'status colorFunctional props retained in base hook
value— current progress value (used for ARIA attributes)max— maximum progress value (used for ARIA attributes, defaults to 1)barslot — filled portion of the trackTest plan
npx tsc -p packages/react-components/react-progress/library/tsconfig.json --noEmit)useProgressBarBase_unstableis exported from the package index🤖 Generated with Claude Code