feat(react-slider): add useSliderBase_unstable hook#35815
Draft
dmytrokirpa wants to merge 2 commits intomasterfrom
Draft
feat(react-slider): add useSliderBase_unstable hook#35815dmytrokirpa wants to merge 2 commits intomasterfrom
dmytrokirpa wants to merge 2 commits intomasterfrom
Conversation
Adds a base state hook for Slider component that extracts pure component logic (ARIA, slot structure, keyboard handling, controlled/uncontrolled state) without the design-related size prop. - Add SliderBaseProps type omitting size (design prop); keeps vertical as it affects aria-orientation behavior via the orient attribute on the input - Add SliderBaseState type omitting size - Add useSliderBase_unstable hook that handles slot setup, focus management, and delegates controlled state to useSliderState_unstable - Refactor useSlider_unstable to call useSliderBase_unstable internally - Export new types and hook from package index.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
dmytrokirpa
force-pushed
the
feat/react-slider-base-hooks
branch
from
72222f8 to
70334a1
Compare
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 495 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 609 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 506 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSliderBase_unstablehook toreact-sliderthat extracts pure component logic without design propsSliderBasePropstype omittingsize(design-related prop);verticalis kept as it affectsaria-orientationbehavior via theorientattribute on the input elementSliderBaseStatetype omittingsizeuseSlider_unstableto calluseSliderBase_unstableinternallyindex.tsWhat base hooks include
The base hook preserves:
root,input,rail,thumbslots)type="range"on inputorientattribute (horizontal/vertical) for Firefox supportuseFocusWithinuseSliderState_unstableuseFieldControlProps_unstabledisabledandverticalbehavioral propsThe base hook excludes:
sizeprop (small/medium - design concern)Test plan
useSliderBase_unstablecan be imported from@fluentui/react-sliderSliderBasePropsandSliderBaseStatetypes are exporteduseSlider_unstablebehavior is unchanged🤖 Generated with Claude Code