Skip to content

feat: support hard delete#205

Open
v-alexmoraru wants to merge 4 commits intomicrosoft:mainfrom
v-alexmoraru:dev/v-alexmoraru/support-hard-delete
Open

feat: support hard delete#205
v-alexmoraru wants to merge 4 commits intomicrosoft:mainfrom
v-alexmoraru:dev/v-alexmoraru/support-hard-delete

Conversation

@v-alexmoraru
Copy link
Copy Markdown
Member

Adds --purge flag to rm command, which permanently deletes the item.

@v-alexmoraru v-alexmoraru requested a review from a team as a code owner April 2, 2026 13:37
Copilot AI review requested due to automatic review settings April 2, 2026 13:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds hard-delete support to the rm command by introducing a new --purge flag that triggers permanent deletion (via hardDelete=true) and updates docs + VCR recordings accordingly.

Changes:

  • Added --purge flag to fab rm and documented the new behavior.
  • Wired --purge through item/workspace deletion flows by setting request query params (hardDelete=true) and adding stronger confirmation messaging.
  • Added/updated VCR recordings covering purge-delete success across multiple item types.

Reviewed changes

Copilot reviewed 39 out of 57 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[SparkJobDefinition].yaml Adds purge-delete success recording for SparkJobDefinition.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Reflex].yaml Adds purge-delete success recording for Reflex.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[MirroredDatabase].yaml Adds purge-delete success recording for MirroredDatabase.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[MLModel].yaml Adds purge-delete success recording for MLModel (async create flow included).
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Lakehouse].yaml Adds purge-delete success recording for Lakehouse.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[KQLQueryset].yaml Adds purge-delete success recording for KQLQueryset.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[KQLDashboard].yaml Adds purge-delete success recording for KQLDashboard.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[GraphQLApi].yaml Adds purge-delete success recording for GraphQLApi.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Eventstream].yaml Adds purge-delete success recording for Eventstream (async create flow included).
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Eventhouse].yaml Adds purge-delete success recording for Eventhouse.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Environment].yaml Adds purge-delete success recording for Environment.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Dataflow].yaml Adds purge-delete success recording for Dataflow.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[DataPipeline].yaml Adds purge-delete success recording for DataPipeline.
tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[CopyJob].yaml Adds purge-delete success recording for CopyJob.
tests/test_commands/recordings/test_commands/test_rm/class_setup.yaml Updates test setup recording (User-Agent/version + workspace ids/contents).
src/fabric_cli/parsers/fab_fs_parser.py Adds --purge flag to rm parser and updates examples/help.
src/fabric_cli/commands/fs/rm/fab_fs_rm_workspace.py Propagates purge deletion to item deletes when deleting items within a workspace flow.
src/fabric_cli/commands/fs/rm/fab_fs_rm_item.py Sets request params for purge deletion when removing a single item.
src/fabric_cli/client/fab_api_utils.py Adds stronger confirmation/warnings for purge deletion, plus minor formatting changes.
docs/commands/fs/rm.md Documents --purge flag and adds examples for soft/force/purge deletion.

Copilot AI review requested due to automatic review settings April 3, 2026 07:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 58 changed files in this pull request and generated 5 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants