Skip to content

Allow TaskFailedError to be constructed from Exception #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andystaples merged 5 commits into from
Jan 8, 2026
Merged

Allow TaskFailedError to be constructed from Exception #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8c3c0f
Allow TaskFailedError to be constructed from Exception
andystaples Jan 7, 2026
d49b351
Propogate inner exceptions in FailureDetails
andystaples Jan 7, 2026
85f8c59
Allow passing exception to fail()
andystaples Jan 8, 2026
8334a74
Recursion prevention
andystaples Jan 8, 2026
6416824
Only log Exceptions, not BaseException
andystaples Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions durabletask/internal/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,18 @@ def new_sub_orchestration_failed_event(event_id: int, ex: Exception) -> pb.Histo
)


def new_failure_details(ex: Exception) -> pb.TaskFailureDetails:
def new_failure_details(ex: Exception, _visited: Optional[set[int]] = None) -> pb.TaskFailureDetails:
if _visited is None:
_visited = set()
_visited.add(id(ex))
inner: Optional[BaseException] = ex.__cause__ or ex.__context__
if len(_visited) > 10 or (inner and id(inner) in _visited) or not isinstance(inner, Exception):
inner = None
return pb.TaskFailureDetails(
errorType=type(ex).__name__,
errorMessage=str(ex),
stackTrace=wrappers_pb2.StringValue(value=''.join(traceback.format_tb(ex.__traceback__)))
stackTrace=wrappers_pb2.StringValue(value=''.join(traceback.format_tb(ex.__traceback__))),
innerFailure=new_failure_details(inner, _visited) if inner else None
)


Expand Down
6 changes: 4 additions & 2 deletions durabletask/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,10 @@ def stack_trace(self) -> Optional[str]:
class TaskFailedError(Exception):
"""Exception type for all orchestration task failures."""

def __init__(self, message: str, details: pb.TaskFailureDetails):
def __init__(self, message: str, details: Union[pb.TaskFailureDetails, Exception]):
super().__init__(message)
if isinstance(details, Exception):
details = pbh.new_failure_details(details)
self._details = FailureDetails(
details.errorMessage,
details.errorType,
Expand Down Expand Up @@ -424,7 +426,7 @@ def complete(self, result: T):
if self._parent is not None:
self._parent.on_child_completed(self)

def fail(self, message: str, details: pb.TaskFailureDetails):
def fail(self, message: str, details: Union[Exception, pb.TaskFailureDetails]):
if self._is_complete:
raise ValueError('The task has already completed.')
self._exception = TaskFailedError(message, details)
Expand Down
Loading