Skip to content

Conversation

@andystaples
Copy link
Contributor

@andystaples andystaples commented Nov 6, 2025

Resolves #54

@andystaples andystaples requested review from berndverst and Copilot and removed request for berndverst November 6, 2025 17:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for calling sub-orchestrators by name (as a string) in addition to the existing support for passing function references. This brings consistency with the call_activity method which already supports both patterns.

  • Updated the call_sub_orchestrator method signature to accept Union[Orchestrator[TInput, TOutput], str]
  • Modified the implementation to handle both string names and function references
  • Added comprehensive end-to-end tests for the new functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
durabletask/task.py Updated abstract method signature to accept string orchestrator names
durabletask/worker.py Implemented logic to handle both string and function reference orchestrators
tests/durabletask/test_orchestration_e2e.py Added test validating sub-orchestrator calls by name
tests/durabletask-azuremanaged/test_dts_orchestration_e2e.py Added test validating sub-orchestrator calls by name for Azure-managed scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow suborchestration name to be passed to call_sub_orchestrator

2 participants