Increase specificity of Task return types #100
Merged
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
berndverst
approved these changes
Jan 8, 2026
larohra
reviewed
Jan 8, 2026
| entity: EntityInstanceId, | ||
| operation: str, | ||
| input: Optional[TInput] = None) -> Task: | ||
| input: Optional[TInput] = None) -> CompletableTask: |
There was a problem hiding this comment.
Shouldn't this also have been CompletableTask[TOutput]?
Suggested change
| input: Optional[TInput] = None) -> CompletableTask: | |
| input: Optional[TInput] = None) -> CompletableTask[TOutput]: |
larohra
reviewed
Jan 8, 2026
| # not received within the specified timeout. This requires support for task cancellation. | ||
| @abstractmethod | ||
| def wait_for_external_event(self, name: str) -> Task: | ||
| def wait_for_external_event(self, name: str) -> CompletableTask: |
There was a problem hiding this comment.
Similarly (here and other places in the changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.