Include Exception Properties at FailureDetails by nytian · Pull Request #474 · microsoft/durabletask-dotnet

nytian · 2025-10-02T15:25:00Z

This PR supports register custom provider that help include exception properties at TaskFailureDetails. Supports include running with both DurableTaskWorker and Durable Functions (.NET Isolated).

Note: related PR :

durabletask.core : Include Exception Types at FailureDetails Azure/durabletask#1237
durabletask.protobuf: Add properties Field to TaskFailureDetails durabletask-protobuf#45

nytian · 2025-10-02T16:38:03Z

test/Grpc.IntegrationTests/GrpcSidecar/Grpc/TaskHubGrpcServer.cs

        }
    }

-    static P.TaskFailureDetails? GetFailureDetails(FailureDetails? failureDetails)


remove this because we will call the one at ptobufutils instead

src/Worker/Core/IExceptionPropertiesProvider.cs

nytian · 2025-10-02T17:50:15Z

src/Abstractions/TaskFailureDetails.cs

            exception.StackTrace,
-            FromExceptionRecursive(exception.InnerException));
+            FromExceptionRecursive(exception.InnerException),
+            null);// might need to udpate this later 


Question for the public static TaskFailureDetails FromException(Exception exception)

I checked all the reference, and it seems all the cases we called this is when the exception is a DTCore.OrchestrationExcep, which means it should already have properties included. Thus currently we don't need to extract properties here.

But I am not sure if there might be a case when the exception is not from dt.core and this return new FailureDetails block is reached. If so, then we need to extract properties in this repo, which means I need to update OrchestrationContextWrapper class etc. But I didn't find a case like this from current code path. Let me know if there is any other thought on this.

…rosoft/durabletask-dotnet into nytian/failure-details-excep

nytian · 2025-10-06T04:00:14Z

src/Worker/Grpc/GrpcOrchestrationRunner.cs

+                    ? new(new(p.Name), p.OrchestrationInstance.InstanceId)
+                    : null;
+
+                DurableTaskShimFactory factory = services is null


I only updated line 211 to 226.. the whole file changed because of the VS outlining thing

I was able to read it properly if I turned off whitespace in the diff view. This can happen sometimes if VS or the git client changes the line endings.

cgillum

A few initial comments. Haven't reviewed everything yet.

src/Abstractions/TaskFailureDetails.cs

cgillum · 2025-10-07T00:49:31Z

src/Grpc/versions.txt

@@ -1,2 +1,2 @@
-# The following files were downloaded from branch main at 2025-09-17 01:45:58 UTC
-https://raw.githubusercontent.com/microsoft/durabletask-protobuf/f5745e0d83f608d77871c1894d9260ceaae08967/protos/orchestrator_service.proto
+# The following files were downloaded from branch nytian/failure-details at 2025-10-01 21:51:24 UTC


Reminder to update this to main once the protobuf changes in durabletask-protobuf are merged.

src/Shared/Grpc/ProtoUtils.cs

src/Abstractions/TaskFailureDetails.cs

test/Grpc.IntegrationTests/GrpcSidecar/Grpc/ProtobufUtils.cs

philliphoff

LGTM, apart from the note about updating the protobuf definitions once that related change is committed.

cgillum

I finished reviewing everything and have a few more minor comments.

cgillum · 2025-10-10T19:35:24Z

src/Worker/Core/Shims/DurableTaskShimFactory.cs

 /// </remarks>
 public class DurableTaskShimFactory
 {
+    public readonly IExceptionPropertiesProvider? exceptionPropertiesProvider;


Was making this public an accident? We should never have public fields.

oh thanks for reminding. I added these at first because I thought we need this when using with durable functions isolated. But the test turns out actually we don't need to propagate provider from worker extensions to here. I just deleted these.

src/Worker/Core/IExceptionPropertiesProvider.cs

src/Worker/Grpc/GrpcDurableTaskWorker.cs

test/Grpc.IntegrationTests/GrpcSidecar/Grpc/ProtobufUtils.cs

cgillum · 2025-10-10T19:42:15Z

src/Worker/Grpc/GrpcOrchestrationRunner.cs

+                    ? new(new(p.Name), p.OrchestrationInstance.InstanceId)
+                    : null;
+
+                DurableTaskShimFactory factory = services is null


I was able to read it properly if I turned off whitespace in the diff view. This can happen sometimes if VS or the git client changes the line endings.

cgillum · 2025-10-10T19:43:08Z

src/Shared/Grpc/ProtoUtils.cs

-                if (orchestrationActivity is null)
-                {
-                    return null;
+                    return DateTime.Parse(stringValue[3..], CultureInfo.InvariantCulture, DateTimeStyles.RoundtripKind);


Same comment about TryParse instead of Parse, though I wonder why we have this same logic in two places?

The grpc integration test will not use the ProtoUtils under folder src/shared/grpc but will use the one at it's own folder which is test/Grpc.IntegrationTests/GrpcSidecar/Grpc/ProtobufUtils.cs

initial commit

c8ff67f

nytian changed the title ~~Include Exception Properties at FailueDetails~~ Include Exception Properties at FailureDetails Oct 2, 2025

nytian commented Oct 2, 2025

View reviewed changes

update

3d4e485

nytian commented Oct 2, 2025

View reviewed changes

src/Worker/Core/IExceptionPropertiesProvider.cs Show resolved Hide resolved

nytian commented Oct 2, 2025

View reviewed changes

nytian and others added 3 commits October 3, 2025 10:24

Update Microsoft.Azure.DurableTask.Core to version 3.5.0

8636a3d

add factory change support for df support

c4321e4

Merge branch 'nytian/failure-details-excep' of https://github.com/mic…

e3a7f8a

…rosoft/durabletask-dotnet into nytian/failure-details-excep

nytian commented Oct 6, 2025

View reviewed changes

nytian added 3 commits October 6, 2025 10:49

update test and version

e98024b

udpate test

121a605

fix issue

c34de93

nytian requested review from YunchuWang and cgillum October 6, 2025 19:34

udpate commment

c084057

cgillum reviewed Oct 7, 2025

View reviewed changes

nytian added 3 commits October 7, 2025 20:48

udpate protoutils

d5f45fe

update dictionary to be object? and update test to include more types

15c8393

udpate comment

221bc3d

nytian requested a review from cgillum October 8, 2025 17:15

nytian mentioned this pull request Oct 8, 2025

Include Exception Properties at FailureDetails via Custom Provider Azure/azure-functions-durable-extension#3215

Merged

15 tasks

philliphoff reviewed Oct 9, 2025

View reviewed changes

src/Abstractions/TaskFailureDetails.cs Outdated Show resolved Hide resolved

philliphoff reviewed Oct 9, 2025

View reviewed changes

test/Grpc.IntegrationTests/GrpcSidecar/Grpc/ProtobufUtils.cs Show resolved Hide resolved

udpate by comemnt

e155c7e

nytian requested a review from philliphoff October 9, 2025 20:38

philliphoff approved these changes Oct 10, 2025

View reviewed changes

cgillum reviewed Oct 10, 2025

View reviewed changes

udpate bu comment

edb5504

nytian requested a review from cgillum October 13, 2025 15:56

cgillum approved these changes Oct 13, 2025

View reviewed changes

udpate grpc

15c86e5

philliphoff approved these changes Oct 13, 2025

View reviewed changes

nytian merged commit 6a1f434 into main Oct 13, 2025
4 checks passed

nytian deleted the nytian/failure-details-excep branch October 13, 2025 18:44

Conversation

nytian commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nytian Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgillum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philliphoff left a comment

Choose a reason for hiding this comment

Uh oh!

cgillum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nytian commented Oct 2, 2025 •

edited

Loading

nytian Oct 2, 2025 •

edited

Loading