Align environment between snapshot publish and verify #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
=======================================
- Coverage 89.6% 89.6% -0.1%
=======================================
Files 384 384
Lines 29930 29930
Branches 1835 1835
=======================================
- Hits 26844 26842 -2
Misses 2696 2696
- Partials 390 392 +2 ☔ View full report in Codecov by Sentry. |
|
After merging this PR, please do not forget to rerun the snapshot publish pipeline so that the changes of this PR are reflected when running the verification pipeline |
|
@FernandoRojo you modified the snapshot publish pipeline at #1294, could you give me some feedback? |
grvillic
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot publish pipeline is missing two env variables that change the behavior of pip and might generate different results because of this.
snapshot-verify.yml
https://github.com/microsoft/component-detection/blob/main/.github/workflows/snapshot-verify.yml#L5
snapshot-publish.yml
https://github.com/microsoft/component-detection/blob/main/.github/workflows/snapshot-publish.yml#L4