Skip to content

Conversation

melotic
Copy link
Member

@melotic melotic commented Feb 19, 2024

Closes #1001

This uses a new environment variable to configure the Rust CLI detector, CD_RUST_CLI_FEATURES. Open to any other ideas on how to pass this into the detector.

@melotic melotic added version:minor type:feature Feature (new functionality) detector:rust The Rust Cargo detector labels Feb 19, 2024
@melotic melotic requested a review from a team as a code owner February 19, 2024 20:37
@melotic melotic requested a review from annaowens February 19, 2024 20:37
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (c2cfd4d) to head (99e9102).
Report is 113 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1009   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files        236     236           
  Lines      10353   10357    +4     
  Branches    1025    1026    +1     
=====================================
+ Hits        7800    7804    +4     
  Misses      2269    2269           
  Partials     284     284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya
Copy link
Contributor

cobya commented Feb 26, 2024

I think it's time to start investing in a file-based configuration approach where we have a top-level service read a file from something like .detection/config.json where we keep these environment variables, but that would probably be outside the scope of this 🤨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:rust The Rust Cargo detector type:feature Feature (new functionality) version:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust: allow specific features to be set for RustCLI detector
2 participants