Add cDac runtime enumeration support #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new DebugLibaryKind.CDac enum used when the data contract export is found on a runtime module. Currently the file path to the cdac is the same directory as the clrmd module. Currently leaves it to the client (SOS in this case) to decide when it wants to instantiate the cdac. The standalone hosting support doesn't currently pick the cdac. Breaking changes: Add "bool verifySignature" to IClrInfoProvider.GetDacServices and remove the CustomDataTarget.DacSignatureVerificationEnabled property. Adds data target support for ICLRContractLocator for when clrmd loads the cdac.
|
/cc: @max-charlamb |
src/Microsoft.Diagnostics.Runtime/Implementation/DotNetClrInfoProvider.cs
Show resolved
Hide resolved
Co-authored-by: Max Charlamb <[email protected]>
leculver
requested changes
Apr 1, 2025
leculver
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new DebugLibaryKind.CDac enum used when the data contract export is found on a runtime module.
Currently the file path to the cdac is the same directory as the clrmd module.
Currently leaves it to the client (SOS in this case) to decide when it wants to instantiate the cdac. The standalone hosting support doesn't currently pick the cdac.
Breaking changes:
Add "bool verifySignature" to IClrInfoProvider.GetDacServices and remove the CustomDataTarget.DacSignatureVerificationEnabled property.
Adds data target support for ICLRContractLocator for when clrmd loads the cdac.