Skip to content

fix(pipewire): disable opus codec support#17227

Open
binujp wants to merge 1 commit into
4.0from
bphilip/opus-pipewire-elide
Open

fix(pipewire): disable opus codec support#17227
binujp wants to merge 1 commit into
4.0from
bphilip/opus-pipewire-elide

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented May 14, 2026

Summary

Disable opus and bluez5-codec-opus in pipewire's meson build config. Opus requires CELA review per Microsoft codec guidance.

Changes

  • Added spec-search-replace overlay to inject -D opus=disabled -D bluez5-codec-opus=disabled into the meson configuration
  • pipewire's meson.build requires opus as a dependency (default: auto) — without this, builds fail when opus-devel is unavailable

Testing

  • Built pipewire successfully
  • Verified pipewire-libs has no opus dependency (rpm -qpR shows no opus)
  • Smoke-tested in mock chroot: pipewire --version works correctly

Part of the opus codec removal effort.

Copilot AI review requested due to automatic review settings May 14, 2026 18:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Disables Opus codec support in PipeWire builds to comply with Microsoft codec guidance and avoid build failures when opus-devel isn’t available.

Changes:

  • Adds Meson flags to disable opus and bluez5-codec-opus during %meson configuration in the spec.
  • Adds a spec-search-replace overlay intended to inject the same Meson disable flags.
  • Updates the pipewire.lock input fingerprint.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
specs/p/pipewire/pipewire.spec Adds Meson args to disable Opus/BlueZ Opus codec support at build time.
base/comps/pipewire/pipewire.comp.toml Adds an overlay to inject the same Meson flags via spec search/replace.
locks/pipewire.lock Updates the input fingerprint to reflect the changed inputs.

Comment thread base/comps/pipewire/pipewire.comp.toml Outdated
Comment thread base/comps/pipewire/pipewire.comp.toml Outdated
@binujp binujp marked this pull request as draft May 14, 2026 18:36
@binujp binujp force-pushed the bphilip/opus-pipewire-elide branch 2 times, most recently from 204581c to 06c5187 Compare May 14, 2026 19:19
Disable opus and bluez5-codec-opus in pipewire's meson build config.
Opus requires CELA review per Microsoft codec guidance.

- Added scoped spec-search-replace overlay targeting the %build section
  to inject -D opus=disabled -D bluez5-codec-opus=disabled
- Bumped baserelease for rebuild

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@binujp binujp force-pushed the bphilip/opus-pipewire-elide branch from 06c5187 to 6f24396 Compare May 15, 2026 05:25
@binujp binujp marked this pull request as ready for review May 15, 2026 05:27
@binujp binujp changed the base branch from tomls/base/main to 4.0 May 15, 2026 22:50
[[components.pipewire.overlays]]
type = "spec-search-replace"
description = "Increment baserelease for opus removal rebuild"
regex = '%global baserelease 1'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a manual release bump method, rather than hardcode the baserelease number which will stop matching if upstream Fedora bumps baserelease, use something like this - a13a100 - to create azl_release to track the number of times we add our Azure Linux adjustments, and then use the RPM arithmetic operation to incorporate %[%{baserelease}+%{azl_release}] into the spec's Release macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants