fix(pipewire): disable opus codec support#17227
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Disables Opus codec support in PipeWire builds to comply with Microsoft codec guidance and avoid build failures when opus-devel isn’t available.
Changes:
- Adds Meson flags to disable
opusandbluez5-codec-opusduring%mesonconfiguration in the spec. - Adds a
spec-search-replaceoverlay intended to inject the same Meson disable flags. - Updates the
pipewire.lockinput fingerprint.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| specs/p/pipewire/pipewire.spec | Adds Meson args to disable Opus/BlueZ Opus codec support at build time. |
| base/comps/pipewire/pipewire.comp.toml | Adds an overlay to inject the same Meson flags via spec search/replace. |
| locks/pipewire.lock | Updates the input fingerprint to reflect the changed inputs. |
204581c to
06c5187
Compare
Disable opus and bluez5-codec-opus in pipewire's meson build config. Opus requires CELA review per Microsoft codec guidance. - Added scoped spec-search-replace overlay targeting the %build section to inject -D opus=disabled -D bluez5-codec-opus=disabled - Bumped baserelease for rebuild Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
06c5187 to
6f24396
Compare
| [[components.pipewire.overlays]] | ||
| type = "spec-search-replace" | ||
| description = "Increment baserelease for opus removal rebuild" | ||
| regex = '%global baserelease 1' |
There was a problem hiding this comment.
Given this is a manual release bump method, rather than hardcode the baserelease number which will stop matching if upstream Fedora bumps baserelease, use something like this - a13a100 - to create azl_release to track the number of times we add our Azure Linux adjustments, and then use the RPM arithmetic operation to incorporate %[%{baserelease}+%{azl_release}] into the spec's Release macro
Summary
Disable opus and bluez5-codec-opus in pipewire's meson build config. Opus requires CELA review per Microsoft codec guidance.
Changes
-D opus=disabled -D bluez5-codec-opus=disabledinto the meson configurationTesting
rpm -qpRshows no opus)pipewire --versionworks correctlyPart of the opus codec removal effort.