Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beejones/service request must show body in debug #287

Merged
merged 12 commits into from
Jan 15, 2025

Conversation

beejones
Copy link
Contributor

@beejones beejones commented Jan 9, 2025

The body was not in the log during debug logging. Fixed

@beejones
Copy link
Contributor Author

beejones commented Jan 9, 2025

@DomAyre
Copy link
Collaborator

DomAyre commented Jan 9, 2025

Privacy-sandbox-dev fix is still in flight so I'll let you know when it's ready.

This PR looks like it's more about adding tests for the unwrap endpoint, can it be two separate PRs?

@DomAyre
Copy link
Collaborator

DomAyre commented Jan 10, 2025

It looks like there's still a lot of changes from #288

I think you can drop changes in all files apart from:

  • ServiceRequest.ts
  • ServiceRequest.test.ts

@beejones
Copy link
Contributor Author

Privacy-sandbox-dev fix is still in flight so I'll let you know when it's ready.

This PR looks like it's more about adding tests for the unwrap endpoint, can it be two separate PRs?

This is not related to only unwrapping (also /key ). While debugging unwrapping, I noticed the body was not listed in the Request debug message. This is now fixed.

@DomAyre
Copy link
Collaborator

DomAyre commented Jan 10, 2025

Privacy-sandbox-dev fix is still in flight so I'll let you know when it's ready.
This PR looks like it's more about adding tests for the unwrap endpoint, can it be two separate PRs?

This is not related to only unwrapping (also /key ). While debugging unwrapping, I noticed the body was not listed in the Request debug message. This is now fixed.

As mentioned in my comment after the one you've quoted, it looks like there are still changes in this PR corresponding to the unwrap key test PR

@beejones
Copy link
Contributor Author

I was working on one machine on both PRs. They must have spoiled. I will fix it.

@beejones
Copy link
Contributor Author

It looks like there's still a lot of changes from #288

I think you can drop changes in all files apart from:

  • ServiceRequest.ts
  • ServiceRequest.test.ts

fixed

@beejones beejones merged commit 0eb22c2 into main Jan 15, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants