Fix ArchiveFilesV2 task to properly handle adding single files to existing archives

[Copilot]

Issue

When using the ArchiveFilesV2 task with rootFolderOrFile pointing to a single file and includeRootFolder: false, adding to an existing archive (replaceExistingArchive: false) fails with a "Nothing to do" error.

Root Cause

The findFiles() function was not correctly handling the case when includeRootFolder is false and rootFolderOrFile points to a single file. The function was using tl.ls(), which is designed to list directory contents but doesn't handle file paths properly.

Fix

Added a check in the findFiles() function to determine if rootFolderOrFile is a file when includeRootFolder is false. If it is a file, the function now returns the basename of the file directly, matching the behavior when includeRootFolder is true.

function findFiles(): string[] {
    if (includeRootFolder) {
        // Existing code...
    } else {
        // Check if rootFolderOrFile is a file
        if (fs.existsSync(rootFolderOrFile) && fs.statSync(rootFolderOrFile).isFile()) {
            return [path.basename(rootFolderOrFile)];
        } else {
            // Existing code for directory case...
        }
    }
}

Testing

Added a new test case Successfully adds a single file to an existing archive that verifies the task can properly add a single file to an existing archive.

Fixes #21033.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• cdn.fwupd.org
  • Triggering command: /usr/bin/fwupdmgr refresh (dns block)
• pkgs.dev.azure.com
  • Triggering command: npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[ivanduplenskikh]

@copilot, could you please add an additional check there with the feature flag DistributedTasks.Task.ArchiveOneFileWithRootFolderInput to ensure it is executed only when this flag is enabled by using tl.getPipelineFeature?

[Copilot]

I've added the feature flag check as requested. The single file handling in the findFiles() function now only works when the DistributedTasks.Task.ArchiveOneFileWithRootFolderInput feature flag is enabled. When the flag is disabled, it falls back to the original behavior. Changes are in commit 481a343.

[Driver-glitch]

Good afternoon, Is the fix for this going to happen soon? We have dependencies for this due to the build pipelines failing.

[dsherret]

@Driver-glitch just do this:

- - task: ArchiveFiles@2
+ - task: [email protected]