Skip to content

add basic logging for test failures #21023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

add basic logging for test failures #21023

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
55ecd59
add basic logging for test failures
sanjays-ms May 13, 2025
3a01c5d
Merge branch 'master' into users/v-sanjayse/gradlev3-logs
mishrarish May 13, 2025
df832a2
updated logging to capture gradle logs
sanjays-ms May 15, 2025
ebace01
task.json file version update
sanjays-ms May 15, 2025
50ddc0f
Merge branch 'master' into users/v-sanjayse/gradlev3-logs
sanjays-ms Jun 15, 2025
df8db98
Merge branch 'master' into users/v-sanjayse/gradlev3-logs
sanjays-ms Jun 15, 2025
5c45827
updated error message handling
sanjays-ms Jun 15, 2025
7a2f2c5
updated task version
sanjays-ms Jun 15, 2025
1f3cb5c
removed std out logs
sanjays-ms Jun 16, 2025
f933f4c
Merge branch 'master' into users/v-sanjayse/gradlev3-logs
sanjays-ms Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Tasks/GradleV3/Modules/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,13 @@ export function resolveTaskResult(codeAnalysisResult: ICodeAnalysisResult): ITas
status = TaskResult.Failed;

if (codeAnalysisResult.statusFailed) {
message = `Code analysis failed. Gradle exit code: ${codeAnalysisResult.gradleResult}. Error: ${codeAnalysisResult.analysisError}`;
} else {
message = `Build failed. Gradle exit code: ${codeAnalysisResult.gradleResult}`;
if (codeAnalysisResult.isTestFailure && !codeAnalysisResult.isCodeAnalysisFailure) {
message = `Tests failed. Gradle exit code: ${codeAnalysisResult.gradleResult}. Error: ${codeAnalysisResult.analysisError}`;
} else if (codeAnalysisResult.isCodeAnalysisFailure) {
message = `Code analysis failed. Gradle exit code: ${codeAnalysisResult.gradleResult}. Error: ${codeAnalysisResult.analysisError}`;
} else {
message = `Build failed. Gradle exit code: ${codeAnalysisResult.gradleResult}. Error: ${codeAnalysisResult.analysisError}`;
}
}
}

Expand Down
17 changes: 17 additions & 0 deletions Tasks/GradleV3/gradletask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,23 @@ async function run() {
codeAnalysisResult.gradleResult = -1;
codeAnalysisResult.statusFailed = true;
codeAnalysisResult.analysisError = err;

const isAnyCodeAnalysisEnabled = tl.getBoolInput('checkstyleAnalysisEnabled', false) || tl.getBoolInput('findbugsAnalysisEnabled', false) || tl.getBoolInput('pmdAnalysisEnabled', false) || tl.getBoolInput('spotBugsAnalysisEnabled', false) || tl.getBoolInput('sqAnalysisEnabled', false);

const errorMsg = err.toString().toLowerCase();
const isTaskNameIndicatesTest = inputTasks.some(task => task.toLowerCase().includes('test') && !task.toLowerCase().includes('setup'));
const errorMsgIndicatesTest = errorMsg.includes('test failure') || errorMsg.includes('tests failed') || errorMsg.includes('failing tests') || (errorMsg.includes('test') && errorMsg.includes('fail'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checks will fail in case of localization i.e. if this is running on some machine with different language. we need a better way to identify what is failing.


const errorMsgIndicatesCodeAnalysis = errorMsg.includes('checkstyle') || errorMsg.includes('pmd') || errorMsg.includes('findbugs') || errorMsg.includes('spotbugs') || errorMsg.includes('sonar') || errorMsg.includes('code analysis') || errorMsg.includes('quality gate');

codeAnalysisResult.isTestFailure = (isTaskNameIndicatesTest || errorMsgIndicatesTest)

codeAnalysisResult.isCodeAnalysisFailure = isAnyCodeAnalysisEnabled && (errorMsgIndicatesCodeAnalysis || (!codeAnalysisResult.isTestFailure));


if (!isAnyCodeAnalysisEnabled) {
codeAnalysisResult.isCodeAnalysisFailure = false;
}

console.error(err);
tl.debug('taskRunner fail');
Expand Down
2 changes: 2 additions & 0 deletions Tasks/GradleV3/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export interface ICodeAnalysisResult {
gradleResult?: number;
statusFailed?: boolean;
analysisError?: any;
isCodeAnalysisFailure?: boolean;
isTestFailure?: boolean;
}

export interface ITaskResult {
Expand Down