Fixes the build failure due to .NET version change #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in detail: #53
error NETSDK1031: It is not supported to build or publish a self-contained application without specifying a RuntimeIdentifier. You must either specify a RuntimeIdentifier or set SelfContained to false. [/Users/dtsapple/CoveragePublisher/azure-pipelines-coveragepublisher/src/CoveragePublisher.Console/CoveragePublisher.Console.csproj]Explain fix
Setting SelfContained to False, removes the need of setting the RuntimeIdentifier which is very personal to the user and can't be hardcoded.
Repro steps:
Install .NET6
dotnet build
Or install on .NET 3.1 (like needed for before
netcoreapp3.1;net462)Why it didn't get caught on pipeline
Because the check ran on commit 68874da
Installs .NET7 but as a user, seeing targetFramework .net6, I updated to 6 (from 3.1) and still faced the build failure.
https://github.com/microsoft/azure-pipelines-coveragepublisher/actions/runs/4685895850/jobs/8303415148